Skip to content

[PWGHF] Add charm D-D-meson femtoscopy workflows - #17998

Open
zhangbiao-phy wants to merge 31 commits into
AliceO2Group:masterfrom
zhangbiao-phy:charm-charm-femto
Open

[PWGHF] Add charm D-D-meson femtoscopy workflows#17998
zhangbiao-phy wants to merge 31 commits into
AliceO2Group:masterfrom
zhangbiao-phy:charm-charm-femto

Conversation

@zhangbiao-phy

@zhangbiao-phy zhangbiao-phy commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Add a FemtoDream producer and analysis task for D0D0 and D0D*+ correlations, including like-sign and unlike-sign flavour combinations. Reuse the existing candidate and collision tables for offline pairing and event mixing. D0 candidates share the two-prong table, while D*+ candidates use the Dstar table. No dedicated D–D pair table is produced. And we only support do offline mixing for this analsyiss.

Tag @fgrosa for infos

@github-actions github-actions Bot added the pwghf PWG-HF label Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title PWGHF: Add charm-charm FemtoDream workflows [PWGHF] Add charm-charm FemtoDream workflows Sep 21, 2026
@alibuild alibuild mentioned this pull request Sep 21, 2026
Merged
@zhangbiao-phy
Merge pull request #85 from alibuild/alibot-cleanup-17998
13a67f1 
Please consider the following formatting changes to AliceO2Group#17998
@zhangbiao-phy
zhangbiao-phy marked this pull request as ready for review September 21, 2026 15:55
@zhangbiao-phy zhangbiao-phy changed the title [PWGHF] Add charm-charm FemtoDream workflows [PWGHF] Add charm D-D-meson femtoscopy workflows Sep 21, 2026
@alibuild

alibuild commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 13a67f1 at 2026-09-21 18:09:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/HFC/Tasks/taskCharmHadronsCharmFemtoDream.cxx:180:44: error: arithmetic between enumeration type 'HfTaskCharmHadronsCharmFemtoDream::PairChannel' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Sep 21, 2026
Merged
@zhangbiao-phy
Merge pull request #86 from alibuild/alibot-cleanup-17998
4e42d3d 
Please consider the following formatting changes to AliceO2Group#17998
@alibuild alibuild mentioned this pull request Sep 21, 2026
Merged
@alibuild alibuild mentioned this pull request Sep 21, 2026
Merged
@vkucera

vkucera commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Something is wrong with your formatting. Please don't break the lines unnecessarily.

vkucera
vkucera reviewed Sep 22, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/producerCharmHadronsCharmFemtoDream.cxx Outdated
vkucera
vkucera reviewed Sep 22, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/producerCharmHadronsCharmFemtoDream.cxx Outdated
vkucera
vkucera reviewed Sep 22, 2026
View reviewed changes
Comment thread PWGHF/HFC/Tasks/taskCharmHadronsCharmFemtoDream.cxx Outdated
vkucera
vkucera reviewed Sep 22, 2026
View reviewed changes
Comment thread PWGHF/HFC/Tasks/taskCharmHadronsCharmFemtoDream.cxx Outdated
vkucera
vkucera reviewed Sep 22, 2026
View reviewed changes
Comment thread PWGHF/HFC/Tasks/taskCharmHadronsCharmFemtoDream.cxx Outdated
vkucera
vkucera reviewed Sep 22, 2026
View reviewed changes
Comment thread PWGHF/HFC/Tasks/taskCharmHadronsCharmFemtoDream.cxx Outdated
vkucera
vkucera reviewed Sep 22, 2026
View reviewed changes
Comment thread PWGHF/HFC/Tasks/taskCharmHadronsCharmFemtoDream.cxx Outdated
@zhangbiao-phy
zhangbiao-phy marked this pull request as ready for review September 22, 2026 13:33
@zhangbiao-phy

zhangbiao-phy commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

@zhangbiao-phy Please test your changes locally before you open a PR for review.

actually I did the test, but I didn't notice the linter warning this time

@alibuild

alibuild commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0fd7d0a at 2026-09-22 20:06:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 0 warnings.'
Found 3 errors and 0 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/299c887240d400edcf4f02b95b6f2af02e33d7ba/O2Physics-code-check/errors.txt
PWGHF/HFC/TableProducer/producerCharmHadronsCharmFemtoDream.cxx:45:1: error: included header OutputObjHeader.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/TableProducer/producerCharmHadronsCharmFemtoDream.cxx:65:25: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/HFC/Tasks/taskCharmHadronsCharmFemtoDream.cxx:31:1: error: included header OutputObjHeader.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

vkucera
vkucera reviewed Sep 22, 2026
View reviewed changes
Comment thread PWGHF/HFC/Tasks/taskCharmHadronsCharmFemtoDream.cxx Outdated
Comment on lines +65 to +71
Configurable<float> ptMinD0{"ptMinD0", 0.f, "Minimum D0 pT"};
Configurable<float> ptMaxD0{"ptMaxD0", 36.f, "Maximum D0 pT"};
Configurable<float> ptMinDstar{"ptMinDstar", 0.f, "Minimum Dstar pT"};
Configurable<float> ptMaxDstar{"ptMaxDstar", 36.f, "Maximum Dstar pT"};
Configurable<float> etaMax{"etaMax", 0.8f, "Maximum absolute candidate eta"};
Configurable<float> massMinD0{"massMinD0", 1.7f, "Minimum D0 mass (keep sidebands)"};
Configurable<float> massMaxD0{"massMaxD0", 2.0f, "Maximum D0 mass"};

@vkucera vkucera Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the logical ordering and fix the names.
"D0 pT" -> ptD0
"maximum D0 pT" -> "maximum ptD0" -> ptD0Max.

@zhangbiao-phy zhangbiao-phy Sep 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@alibuild

alibuild commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 3154a04 at 2026-09-22 22:00:

No log files found

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangbiao-phy @alibuild @vkucera