Skip to content

[PWGLF] Add production plane and random plane, plus the phi part for … - #18025

Open
sarjeetagami wants to merge 3 commits into
AliceO2Group:masterfrom
sarjeetagami:master
Open

[PWGLF] Add production plane and random plane, plus the phi part for …#18025
sarjeetagami wants to merge 3 commits into
AliceO2Group:masterfrom
sarjeetagami:master

Conversation

@sarjeetagami

@sarjeetagami sarjeetagami commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

…cross-checks, in kstarpbpb.cxx; clean up phianalysisrun3pbpb

sarjeeta gami sarjeeta gami
[PWGLF] Add production plane and random plane, plus the phi part for …
5bb1afe 
…cross-checks, in kstarpbpb.cxx; clean up phianalysisrun3pbpb
@github-actions github-actions Bot added the pwglf label Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@sarjeetagami
sarjeetagami marked this pull request as ready for review September 23, 2026 10:54
@alibuild

alibuild commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5bb1afe at 2026-09-23 14:13:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260923-0000/daily-20260923-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 6 warnings.'
Found 1 errors and 6 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/acb3fe362f22248cf05aa43dec8523fe84cc6d3c/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:52:1: error: included header TF1.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/acb3fe362f22248cf05aa43dec8523fe84cc6d3c/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarpbpb.cxx:534:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:689:12: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:702:14: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
PWGLF/Tasks/Resonances/kstarpbpb.cxx:1454:12: warning: use designated initializer list to initialize 'SAValues' [modernize-use-designated-initializers]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:413:12: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/phianalysisrun3pbpb.cxx:451:12: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

sarjeeta gami sarjeeta gami
[PWGLF] Fix code-check issues in kstarpbpb.cxx and phianalysisrun3pbp…
d68584a 
…b.cxx

Remove the unused TF1.h include, return braced initializer lists for
XYZVector and SAValues, and simplify the negated boolean expressions
flagged by clang-tidy.
@sarjeetagami
sarjeetagami marked this pull request as draft September 23, 2026 12:23
@sarjeetagami
sarjeetagami marked this pull request as ready for review September 23, 2026 12:35
@alibuild

alibuild commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for d68584a at 2026-09-23 17:04:

No log files found

Full log here.

@alibuild

alibuild commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d68584a at 2026-09-23 17:05:

No log files found

Full log here.

@sarjeetagami
sarjeetagami marked this pull request as draft September 23, 2026 17:13
@sarjeetagami
sarjeetagami marked this pull request as ready for review September 23, 2026 17:35
@alibuild

alibuild commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 00aabd1 at 2026-09-23 19:49:

No log files found

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarjeetagami @alibuild