PWGHF: Handle ambiguous tracks in B0 candidate creator and get bz from CCDB#2280
Merged
Conversation
added 2 commits
March 27, 2023 15:37
…ed to this collision and over tracks attached to this collision
fgrosa
requested changes
Mar 28, 2023
| auto covMatrixPV = primaryVertex.getCov(); | ||
|
|
||
| if (ncol % 10000 == 0) { | ||
| LOG(info) << ncol << " collisions parsed"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| LOG(info) << ncol << " collisions parsed"; | |
| LOG(debug) << ncol << " collisions parsed"; |
| Filter filterSelectTracks = (!usePionIsGlobalTrackWoDCA) || ((usePionIsGlobalTrackWoDCA) && requireGlobalTrackWoDCAInFilter()); | ||
| Filter filterSelectCandidates = (aod::hf_sel_candidate_dplus::isSelDplusToPiKPi >= selectionFlagD); | ||
|
|
||
| using TracksWithSelFiltered = soa::Filtered<TracksWithSel>; |
Collaborator
There was a problem hiding this comment.
unfortunately we cannot filter them because otherwise the lookup of the track index (see auto trackPion = trackId.track_as<TracksWithSelFiltered>();) might fail if the track has been filtered out
| std::array<float, 3> pVec2; // = {track2.px(), track2.py(), track2.pz()}; | ||
|
|
||
| o2::dataformats::DCA dca0; | ||
| // dca0.set(track0.dcaXY(), track0.dcaZ()); |
Collaborator
There was a problem hiding this comment.
I would keep the initialisation (it will change only if track.collisionId() != thisCollId, otherwise the default one is the good one)
Comment on lines
+179
to
+181
| std::array<float, 3> pVec0; // = {track0.px(), track0.py(), track0.pz()}; | ||
| std::array<float, 3> pVec1; // = {track1.px(), track1.py(), track1.pz()}; | ||
| std::array<float, 3> pVec2; // = {track2.px(), track2.py(), track2.pz()}; |
Collaborator
There was a problem hiding this comment.
I would keep the initialisation (it will change only if track.collisionId() != thisCollId, otherwise the default one is the good one)
|
|
||
| for (const auto& trackId : trackIdsThisCollision) { // start loop over track indices associated to this collision | ||
| auto trackPion = trackId.track_as<TracksWithSelFiltered>(); | ||
|
|
Collaborator
There was a problem hiding this comment.
Here we should add the selections that we cannot have in the filter anymore
AlexBigO
requested review from
alibuild,
fcolamar,
ginnocen and
vkucera
as code owners
AlexBigO
changed the title
fgrosa
approved these changes
Mar 29, 2023
vkucera
approved these changes
Mar 30, 2023
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Apr 3, 2023
…m CCDB (AliceO2Group#2280) * Change structure: loop over aod::Collisions, over D candidates attached to this collision and over tracks attached to this collision * Repropagate 3prong daughters to this collision if needed + Apply fixes * PR comments * Modify initialization of dca for D daughters * Get bz from CCDB --------- Co-authored-by: Alexandre Bigot <abigot@sbgat402.in2p3.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @fgrosa ! Here is the new structure of the code:
aod::Collision const& collisionspVecof these daughters at this vertex (previsouly, I was getting the impulsion of thetrack0,1,2and not thepVecvalues (modified bygetPxPyPz).Is it better to call
getPxPyPz(from trackUtilities.h) orgetPxPyPzGlo(from TrackParametrization) ?Also, I had two remarks:
pVec0,1,2as I update it viagetPxPyPz;dca0,1,2but don't initialize it because it is modified bypropagateToDCA(when called) and because I don't use the dca of the D daughters anyway.If this is okay, I will remove the comments on these lines.
New modifications applied:
getPxPyPzGloo2::dataformat::DCAobjects for D daughtersbzvalue from CCDB