Fix compiler warnings in TriggerAliases.h and EventSelection.h#270
Closed
victor-gonzalez wants to merge 1 commit into
Closed
Fix compiler warnings in TriggerAliases.h and EventSelection.h#270victor-gonzalez wants to merge 1 commit into
TriggerAliases.h and EventSelection.h#270victor-gonzalez wants to merge 1 commit into
Conversation
The eventSelectionLabels are not used so they were removed If they are needed something similar to the aliasLabels would be needed
victor-gonzalez
requested review from
a team,
alibuild,
ginnocen,
iarsene,
jgrosseo,
ktf and
vkucera
as code owners
jgrosseo
requested changes
Nov 11, 2021
jgrosseo
left a comment
jgrosseo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @victor-gonzalez for proposing this. We are currently discussing how this could be solved for good for variables which may be needed in the header. I put this on hold for now.
Collaborator
Author
|
OK |
Merged
ddobrigk
added a commit
that referenced
this pull request
Mar 27, 2024
) * PWGLF: preparations for debug + findable study * Please consider the following formatting changes (#269) * Add V0 selections on detector properties QA plots + re-shuffle selections on TPC/TOF QA plots * Refactor QAs to be flat, no dependence on each other, isolate heavy QA * Refactor / improve organization, doDetectPropQA 2 mode added * Do filling of 5d histos if desired * Please consider the following formatting changes (#270) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com> Co-authored-by: romainschotter <romain.schotter@gmail.com>
vkucera
pushed a commit
to vkucera/O2Physics
that referenced
this pull request
Mar 27, 2024
…iceO2Group#5387) * PWGLF: preparations for debug + findable study * Please consider the following formatting changes (AliceO2Group#269) * Add V0 selections on detector properties QA plots + re-shuffle selections on TPC/TOF QA plots * Refactor QAs to be flat, no dependence on each other, isolate heavy QA * Refactor / improve organization, doDetectPropQA 2 mode added * Do filling of 5d histos if desired * Please consider the following formatting changes (AliceO2Group#270) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com> Co-authored-by: romainschotter <romain.schotter@gmail.com>
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
…iceO2Group#5387) * PWGLF: preparations for debug + findable study * Please consider the following formatting changes (AliceO2Group#269) * Add V0 selections on detector properties QA plots + re-shuffle selections on TPC/TOF QA plots * Refactor QAs to be flat, no dependence on each other, isolate heavy QA * Refactor / improve organization, doDetectPropQA 2 mode added * Do filling of 5d histos if desired * Please consider the following formatting changes (AliceO2Group#270) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com> Co-authored-by: romainschotter <romain.schotter@gmail.com>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
…iceO2Group#5387) * PWGLF: preparations for debug + findable study * Please consider the following formatting changes (AliceO2Group#269) * Add V0 selections on detector properties QA plots + re-shuffle selections on TPC/TOF QA plots * Refactor QAs to be flat, no dependence on each other, isolate heavy QA * Refactor / improve organization, doDetectPropQA 2 mode added * Do filling of 5d histos if desired * Please consider the following formatting changes (AliceO2Group#270) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com> Co-authored-by: romainschotter <romain.schotter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
eventSelectionLabelsare not used so they were removedIf they were needed something similar to the
aliasLabelswould be needed