Included close pair rejection in trigger, ppp trigger, fix in V0 checks#271
Merged
Conversation
lauraser
commented
Nov 11, 2021
lauraser
commented
Collaborator
- Close pair rejection included in trigger,
- ppp trigger added,
- obtaining V0 daughters from table had a bug, fixed in both FemtoDreamDetaDphiStar and FemtoDreamPairCleaner cases.
lauraser
requested review from
alibuild,
jgrosseo,
mpuccio,
saganatt and
victor-gonzalez
as code owners
victor-gonzalez
approved these changes
Nov 12, 2021
| Configurable<int> Q3Trigger{"Q3Trigger", 0, "Choice which trigger to run"}; | ||
| Configurable<float> ldeltaPhiMax{"ldeltaPhiMax", 0.017, "Max limit of delta phi"}; | ||
| Configurable<float> ldeltaEtaMax{"ldeltaEtaMax", 0.017, "Max limit of delta eta"}; | ||
| Configurable<float> lmagfield{"lmagfield", 0.5, "Magnetic field value"}; |
Collaborator
There was a problem hiding this comment.
You don't need a configurable for the magnetic field any longer
Have a look at https://github.com/AliceO2Group/O2Physics/blob/master/PWGCF/Tasks/correlations.cxx#L162
Collaborator
Author
There was a problem hiding this comment.
Thanks a lot for pointing to this example, Victor! Vale is implementing this now, but I want to merge the trigger code now as it is so that I can test it on hyperloop over the weekend. Next week we will include the magnetic field information appropriately.
jgrosseo
approved these changes
Nov 12, 2021
Contributor
|
Waiting for @mpuccio approval... |
mpuccio
approved these changes
Nov 12, 2021
ddobrigk
added a commit
that referenced
this pull request
Mar 27, 2024
* MM: particles 2 tracks alternate process test * Please consider the following formatting changes (#271) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
* MM: particles 2 tracks alternate process test * Please consider the following formatting changes (AliceO2Group#271) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
* MM: particles 2 tracks alternate process test * Please consider the following formatting changes (AliceO2Group#271) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.