DPL Analysis: remove uses of selected packs#4644
Merged
Merged
Conversation
aalkin
requested review from
a team,
alibuild,
ddobrigk,
iarsene,
jgrosseo,
ktf,
mpuccio and
strogolo
as code owners
Member
|
@mpuccio can you please review this and eventually merge? It's blocking other cleanups we would like to do in O2 to improve the compile time. |
mpuccio
approved these changes
Feb 17, 2024
Collaborator
|
I can't merge directly as this PR touches another directory as well, but OK for me. |
jgrosseo
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes uses of selected packs from O2Physics, so that we can proceed with removing their recursive template definitions from O2. This will eventually considerably improve compilation times.