CCDB: do not include AnalysisHelpers.h in ROOT dictionaries - #4761
Merged
Conversation
aalkin
marked this pull request as ready for review
February 21, 2024 11:46
aalkin
requested review from
alibuild,
ddobrigk,
ekryshen,
iarsene and
jgrosseo
as code owners
February 21, 2024 11:46
mpuccio
enabled auto-merge (squash)
February 21, 2024 14:37
Collaborator
|
Good for me! Thanks |
ddobrigk
approved these changes
Feb 21, 2024
basiach
pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @mpuccio
This removes include of
AnalysisHelpers.has to not expose ASoA stuff to root cling - it breaks on c++20 features on linux - unblocking AliceO2Group/AliceO2#12724.Instead of
Servicewrapper the fetcher functions can use bare pointer. As I understand this is not used in O2Physics, but in QC? One would have to change the invocations to use the pointer from the service (accessible directly as.service).