Rename HF tables, adjust index to V0#501
Conversation
|
For some reason clang started inserting spaces after comments, this makes the diff a bit cluttered. Have a look how I reworked the index to V0, this is more than renaming. |
| DECLARE_SOA_INDEX_COLUMN_FULL(Index0, index0, int, Tracks, "_0"); //! Index to first prong | ||
| DECLARE_SOA_INDEX_COLUMN_FULL(Index1, index1, int, Tracks, "_1"); //! Index to second prong | ||
| DECLARE_SOA_INDEX_COLUMN_FULL(Index2, index2, int, Tracks, "_2"); //! Index to third prong | ||
| DECLARE_SOA_INDEX_COLUMN(V0, v0); //! Index to V0 prong |
There was a problem hiding this comment.
This makes the names of index columns inconsistent as only the track column names start with Index.
Actually, I would suggest to rename Index to Prong because when the column getter is called, one gets the prong table row itself, not its index (which is returned by Id). So my proposal is: Prong0,..., ProngV0.
@jgrosseo @ginnocen What do you think?
There was a problem hiding this comment.
I am fine with your proposal, as long as the branch names in the tree stay as they are (which they do with your proposal).
As you see I didn't touch the names of the track columns, they were like this already before.
Is it OK if we merge this and you make the modifications of the names in a subsequent PR?
There was a problem hiding this comment.
Btw. the AliPhysics PR has been merged, so if you update the validation fw will produce the HF tables already. You have to add the wagon HFCandidateCreator before the converter, see https://alimonitor.cern.ch/trains/train.jsp?train_id=132
There was a problem hiding this comment.
I am fine with your proposal, as long as the branch names in the tree stay as they are (which they do with your proposal).
As you see I didn't touch the names of the track columns, they were like this already before.
Is it OK if we merge this and you make the modifications of the names in a subsequent PR?
Yes, it is fine.
There was a problem hiding this comment.
OK. Merged.
DECLARE_SOA_INDEX_COLUMN(V0, v0); will then become DECLARE_SOA_INDEX_COLUMN_FULL(ProngV0, prongV0, int, V0, "");
(note the empty argument)
You may consider also making prongD0 for the D*
* add V0Link table to finder * Rename HF tables, adjust index to V0
2 participants
No description provided.