PWGHF: removing index from FullPs tree - #5061
Merged
Merged
Conversation
cterrevo
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
mfaggin,
mmazzilli,
nzardosh and
vkucera
as code owners
March 8, 2024 11:41
vkucera
changed the title
fcatalan92
reviewed
Mar 8, 2024
fcatalan92
left a comment
fcatalan92
left a comment
Collaborator
There was a problem hiding this comment.
Hi @cterrevo, thanks for the fix!
Could you extend it also to the other tables produced by the task and remove the related column definitions, which shouldn't be needed anymore?
fcatalan92
approved these changes
Mar 12, 2024
fcatalan92
left a comment
fcatalan92
left a comment
Collaborator
There was a problem hiding this comment.
Hi @cterrevo, thanks a lot for having addressed my comments
fcatalan92
enabled auto-merge (squash)
March 12, 2024 09:00
wuctlby
pushed a commit
to wuctlby/O2Physics
that referenced
this pull request
Mar 12, 2024
* removing index from FullPs tree * PWGHF: removing indices from all trees in XicpKpi * removing column with index
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
* removing index from FullPs tree * PWGHF: removing indices from all trees in XicpKpi * removing column with index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing issue of unbound indices in XicpKpi MC trees