PWGHF: Adding D0 to taskFlowCharmHadrons, including Ml.#5087
Closed
wuctlby wants to merge 7 commits into
Closed
Conversation
wuctlby
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
mfaggin,
mmazzilli,
nzardosh and
vkucera
as code owners
Please consider the following formatting changes to AliceO2Group#5087
vkucera
requested changes
Mar 11, 2024
| tracksQx.push_back(cos(harmonic * phiTrack2) * pTtrack2 / ampl); | ||
| tracksQy.push_back(sin(harmonic * phiTrack2) * pTtrack2 / ampl); | ||
|
|
||
| if constexpr (DecayChannel != DecayChannel::D0ToPiK) { |
Collaborator
There was a problem hiding this comment.
Please avoid this kind of confusing naming patterns. DecayChannel on the left is a variable, DecayChannel on the right is a type.
Contributor
Author
There was a problem hiding this comment.
Sorry, I have closed this PR due to a failed submission and will resubmit. I'll change or explain existing comments.
Comment on lines
+170
to
+171
| tracksQx.push_back(cos(harmonic * phiTrack2) * pTtrack2 / ampl); | ||
| tracksQy.push_back(sin(harmonic * phiTrack2) * pTtrack2 / ampl); |
Collaborator
There was a problem hiding this comment.
Explicitly state the namespace you use.
| Configurable<int> centDetector{"centDetector", 0, "Detector for centrality estimation (V0A: 0, T0M: 1, T0A: 2, T0C: 3"}; | ||
| Configurable<int> centDetector{"centDetector", 0, "Detector for centrality estimation (V0A: 0, T0M: 1, T0A: 2, T0C: 3)"}; | ||
| Configurable<int> selectionFlag{"selectionFlag", 1, "Selection Flag for hadron (e.g. 1 for skimming, 3 for topo. and kine., 7 for PID)"}; | ||
| Configurable<int> prongNum{"prongNum", 3, "Number of candidate's prong (For D0, set selectionFlag = 1 and prongNum = 2)"}; |
Collaborator
There was a problem hiding this comment.
Suggested change
| Configurable<int> prongNum{"prongNum", 3, "Number of candidate's prong (For D0, set selectionFlag = 1 and prongNum = 2)"}; | |
| Configurable<int> nProngs{"nProngs", 3, "Number of candidate's prong (For D0, set selectionFlag = 1 and nProngs = 2)"}; |
Why does this have to be set manually?
Contributor
Author
|
This is the new https://github.com/AliceO2Group/O2Physics/pull/5089 @vkucera. Thank you for the comment. |
Collaborator
|
@Libeiyu In general, there is no reason to close a PR and open a new one from the same branch. The new PR will be identical with the closed one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.