Skip to content

PWGUD: Analysis in photonuclear events - #5095

Merged
rolavick merged 19 commits into
AliceO2Group:masterfrom
JosueMtzGar:localtest
Apr 25, 2024
Merged

PWGUD: Analysis in photonuclear events#5095
rolavick merged 19 commits into
AliceO2Group:masterfrom
JosueMtzGar:localtest

Conversation

@JosueMtzGar

Copy link
Copy Markdown
Contributor

First code to start a mean pT and angular correlation analysis in photonuclear events

@aalkin aalkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch on the current master, lumiStability.cxx already contains these changes.

aalkin
aalkin previously approved these changes Mar 12, 2024
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b2c43d4 at 2024-03-13 03:09:

No log files found

Full log here.

@JosueMtzGar

Copy link
Copy Markdown
Contributor Author

the conflicts were resolved

@aalkin

aalkin commented Mar 20, 2024

Copy link
Copy Markdown
Member

I was accidentally assigned to review this, due to extra files affected. I cannot merge this, since @pbuehler is the one responsible for PWGUD.

@JosueMtzGar

Copy link
Copy Markdown
Contributor Author

@pbuehler, could you review this PR please?

@abylinkin

Copy link
Copy Markdown
Contributor

Hi Josue,

I see you requested review and then made 6 commits to the repository after this.
I would suggest that you first convert your project to draft, make all necessary commits and then request a review.
Each new commit (even clang-format or fixing Mega-linter errors) would require the new review from us.

Can you confirm that this iteration is final?

Thank you!

@JosueMtzGar

Copy link
Copy Markdown
Contributor Author

Hi

Thanks for let me know that information, I did not know it. I will be careful the next times.
And yes, that was my final iteration.

Thanks!

@rolavick
rolavick enabled auto-merge (squash) April 23, 2024 07:28
@aortizve

Copy link
Copy Markdown
Collaborator

+1

@rolavick rolavick closed this Apr 23, 2024
auto-merge was automatically disabled April 23, 2024 19:10

Pull request was closed

@rolavick rolavick reopened this Apr 23, 2024
@rolavick
rolavick enabled auto-merge (squash) April 23, 2024 19:11
@aalkin
aalkin self-requested a review April 25, 2024 14:04
@rolavick
rolavick merged commit e17cbd5 into AliceO2Group:master Apr 25, 2024
@JosueMtzGar
JosueMtzGar deleted the localtest branch May 1, 2024 20:00
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
* PWGUD: Analysis in photonuclear events

* formatting issues

* update with process switch

* ;

* Update

* format issue

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
* PWGUD: Analysis in photonuclear events

* formatting issues

* update with process switch

* ;

* Update

* format issue

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes

* new changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants