Skip to content

PWGHF: bitmask for ev. selection and collision process in candidate creators.#5141

Merged
vkucera merged 11 commits into
AliceO2Group:masterfrom
mfaggin:countHfEvents
Mar 14, 2024
Merged

PWGHF: bitmask for ev. selection and collision process in candidate creators.#5141
vkucera merged 11 commits into
AliceO2Group:masterfrom
mfaggin:countHfEvents

Conversation

@mfaggin

@mfaggin mfaggin commented Mar 13, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@mfaggin mfaggin marked this pull request as ready for review March 13, 2024 17:49

@fgrosa fgrosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfaggin, many thanks for the development! I only have a couple of minor comments

Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
Comment thread PWGHF/Utils/utilsMonitorCollisions.h Outdated

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first suggestions.

Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
Comment thread PWGHF/TableProducer/candidateCreator2Prong.cxx Outdated
Comment thread PWGHF/Utils/utilsMonitorCollisions.h Outdated
Comment thread PWGHF/Utils/utilsMonitorCollisions.h Outdated
Comment thread PWGHF/Utils/utilsMonitorCollisions.h Outdated
Comment thread PWGHF/Utils/utilsMonitorCollisions.h Outdated
@mfaggin

mfaggin commented Mar 13, 2024

Copy link
Copy Markdown
Collaborator Author

thanks @fgrosa @vkucera I have addressed your comments

@mfaggin

mfaggin commented Mar 14, 2024

Copy link
Copy Markdown
Collaborator Author

Hi @fgrosa @vkucera as discussed this morning I've implemented the possibility to make the collision processes optional, and not always activated (see this commit 9576674)

Comment thread PWGHF/TableProducer/candidateCreator2Prong.cxx Outdated
Comment thread PWGHF/Utils/utilsEvSelHf.h Outdated
Comment thread PWGHF/TableProducer/candidateCreator2Prong.cxx
fgrosa
fgrosa previously approved these changes Mar 14, 2024

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfaggin

@vkucera vkucera enabled auto-merge (squash) March 14, 2024 17:18
@vkucera vkucera merged commit eda4e6a into AliceO2Group:master Mar 14, 2024
@mfaggin mfaggin deleted the countHfEvents branch March 15, 2024 07:51
wuctlby pushed a commit to wuctlby/O2Physics that referenced this pull request Mar 17, 2024
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants