PWGHF: added BDT scores to Charm resonances analysis #5689
Merged
Conversation
Luca610
commented
Apr 18, 2024
Luca610
commented
Contributor
- dataCreatorCharmResoReduced and candidateCreatorCharmResoReduced: added separate process functions for ML selections
- candidateCreatorCharmResoReduced: added process function for Xc wrong sign candidate reconstruction
- treeCreatorDplusToPiKPi: added Z component of daughters impact parameters to use in BDT training
…er to Dplus tree creator
Luca610
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
mfaggin,
mmazzilli,
nzardosh and
vkucera
as code owners
Please consider the following formatting changes to AliceO2Group#5689
fgrosa
requested changes
Apr 22, 2024
fgrosa
left a comment
fgrosa
left a comment
Collaborator
There was a problem hiding this comment.
Hi @Luca610, the PR looks very good to me, thanks a lot for the work!
I would just suggest you to add the impact parameters Z in the class for the BDT inference https://github.com/AliceO2Group/O2Physics/blob/master/PWGHF/Core/HfMlResponseDplusToPiKPi.h, so that it is done everywhere consistently.
Contributor
Author
|
Hi @fgrosa , thanks for your comment! |
fgrosa
approved these changes
Apr 22, 2024
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
* merged changes to Dplus task on master * marginal change * Please consider the following formatting changes * Please consider the following formatting changes * Please consider the following formatting changes * try2 * first draft for addition of ML tables to Charm Reso analysis * first draft of data creator * sync Dplus Task * added ML scores table to ReducedDataModel.h * added BDT scores to Reso candidate creator and added Z impact parameter to Dplus tree creator * Please consider the following formatting changes * Added new line at the end of taskDplus.cxx --------- Co-authored-by: luagliet <luca.aglietta@cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
* merged changes to Dplus task on master * marginal change * Please consider the following formatting changes * Please consider the following formatting changes * Please consider the following formatting changes * try2 * first draft for addition of ML tables to Charm Reso analysis * first draft of data creator * sync Dplus Task * added ML scores table to ReducedDataModel.h * added BDT scores to Reso candidate creator and added Z impact parameter to Dplus tree creator * Please consider the following formatting changes * Added new line at the end of taskDplus.cxx --------- Co-authored-by: luagliet <luca.aglietta@cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.