PWGHF: add selection on generated PV z position in creators - #5839
Merged
Conversation
fgrosa
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
hahassan7,
mfaggin,
mmazzilli,
nzardosh and
vkucera
as code owners
April 25, 2024 09:13
mfaggin
previously approved these changes
Apr 25, 2024
Please consider the following formatting changes to AliceO2Group#5839
mfaggin
previously approved these changes
Apr 25, 2024
vkucera
requested changes
Apr 25, 2024
Collaborator
Author
Collaborator
vkucera
reviewed
Apr 25, 2024
Collaborator
Author
Contributor
|
Hi @fgrosa, if you don't mind, I think it would be a useful implementation also in the candidateCreatorToXiPi, thanks! |
Collaborator
Author
I will do it in a separated PR not to delay this one (I am now following the PB). |
vkucera
approved these changes
Apr 25, 2024
fgrosa
enabled auto-merge (squash)
April 25, 2024 16:04
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
…roup#5839) * PWGHF: add selection on generated PV z position in creators * Please consider the following formatting changes * Add missing consumption of mcCollision table * Add break and const * Add missing breaks --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
…roup#5839) * PWGHF: add selection on generated PV z position in creators * Please consider the following formatting changes * Add missing consumption of mcCollision table * Add break and const * Add missing breaks --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the selection on the generated PV z position. In order to avoid human mistakes, the same value used in the reconstructed part is retrieved by the workflow of the reconstructed part. Not yet implemented for the XiPi creator because no event selection is present for the XiPi creator for the reconstructed part (@ZFederica let me know if you want me to include it).