PWGHF:Set the correlation status#6290
Merged
Merged
Conversation
1481014945
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
nzardosh and
vkucera
as code owners
fgrosa
requested changes
May 29, 2024
fgrosa
left a comment
fgrosa
left a comment
Collaborator
There was a problem hiding this comment.
Hi @1481014945 I just have few minor comments about the name of the variables, then we can merge it
| DECLARE_SOA_COLUMN(MDbar, mDbar, float); //! Invariant mass of D0bar | ||
| DECLARE_SOA_COLUMN(SignalStatus, signalStatus, int); //! Tag for D0,D0bar | ||
| DECLARE_SOA_COLUMN(PoolBin, poolBin, int); //! Pool Bin for the MixedEvent | ||
| DECLARE_SOA_COLUMN(CorrelationStatus, correlationStatus, bool); //! Correlation Status |
Collaborator
There was a problem hiding this comment.
I would call it with a more meaningful name
Suggested change
| DECLARE_SOA_COLUMN(CorrelationStatus, correlationStatus, bool); //! Correlation Status | |
| DECLARE_SOA_COLUMN(IsAutoCorrelated, isAutoCorrelated, bool); //! Correlation Status |
| aod::hf_correlation_d0_hadron::PtHadron, | ||
| aod::hf_correlation_d0_hadron::PoolBin); | ||
| aod::hf_correlation_d0_hadron::PoolBin, | ||
| aod::hf_correlation_d0_hadron::CorrelationStatus); |
Collaborator
There was a problem hiding this comment.
Suggested change
| aod::hf_correlation_d0_hadron::CorrelationStatus); | |
| aod::hf_correlation_d0_hadron::IsAutoCorrelated); |
| Configurable<float> multMax{"multMax", 10000., "maximum multiplicity accepted"}; | ||
| Configurable<float> ptSoftPionMax{"ptSoftPionMax", 3 * 800. * pow(10., -6.), "max. pT cut for soft pion identification"}; | ||
| Configurable<bool> correlateD0WithLeadingParticle{"correlateD0WithLeadingParticle", false, "Switch for correlation of D0 mesons with leading particle only"}; | ||
| Configurable<bool> setCorrelationState{"setCorrelationState", false, "Set correlation state"}; |
Collaborator
There was a problem hiding this comment.
Suggested change
| Configurable<bool> setCorrelationState{"setCorrelationState", false, "Set correlation state"}; | |
| Configurable<bool> storeAutoCorrelationFlag{"storeAutoCorrelationFlag", false, "Store flag that indicates if the track is paired to its D-meson mother instead of skipping it"}; |
| bool correlationStatus = false; | ||
| if ((candidate1.prong0Id() == track.globalIndex()) || (candidate1.prong1Id() == track.globalIndex())) { | ||
| continue; | ||
| if (!setCorrelationState) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (!setCorrelationState) { | |
| if (!storeAutoCorrelationFlag) { |
| bool correlationStatus = false; | ||
| if ((candidate1.prong0Id() == track.globalIndex()) || (candidate1.prong1Id() == track.globalIndex())) { | ||
| continue; | ||
| if (!setCorrelationState) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (!setCorrelationState) { | |
| if (!storeAutoCorrelationFlag) { |
fgrosa
approved these changes
May 30, 2024
nasirmehdimalik
pushed a commit
to nasirmehdimalik/O2Physics
that referenced
this pull request
Jun 6, 2024
* Add files via upload * Add files via upload * Add files via upload * Add files via upload * Delete PWGHF/DataModel/correlatorD0Hadrons.cxx * Add files via upload * Delete PWGHF/HFC/TableProducer/CorrelationTables.h * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload
GiorgioAlbertoLucia
pushed a commit
to GiorgioAlbertoLucia/O2Physics
that referenced
this pull request
Jul 9, 2024
* Add files via upload * Add files via upload * Add files via upload * Add files via upload * Delete PWGHF/DataModel/correlatorD0Hadrons.cxx * Add files via upload * Delete PWGHF/HFC/TableProducer/CorrelationTables.h * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload
echizzal
pushed a commit
to echizzal/O2Physics
that referenced
this pull request
Jul 18, 2024
* Add files via upload * Add files via upload * Add files via upload * Add files via upload * Delete PWGHF/DataModel/correlatorD0Hadrons.cxx * Add files via upload * Delete PWGHF/HFC/TableProducer/CorrelationTables.h * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have added a column to set the correlation status. You can see my changes here. Can you give me some suggestions?