Skip to content

[PID TOF] Realign naming before upgrade#6410

Merged
njacazio merged 3 commits into
AliceO2Group:masterfrom
njacazio:nj-tofpid
Jun 8, 2024
Merged

[PID TOF] Realign naming before upgrade#6410
njacazio merged 3 commits into
AliceO2Group:masterfrom
njacazio:nj-tofpid

Conversation

@njacazio

@njacazio njacazio commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@njacazio njacazio requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners June 7, 2024 04:55
@alibuild

alibuild commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for fda5dd8 at 2024-06-07 08:25:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:230:25: error: 'class o2::pid::tof::TOFResoParamsV2' has no member named 'printShiftParameters'; did you mean 'setShiftParameters'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:247:23: error: 'class o2::pid::tof::TOFResoParamsV2' has no member named 'printShiftParameters'; did you mean 'setShiftParameters'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/PWGLF/TableProducer/Nuspex/decay3bodybuilder.cxx:358:79: error: 'class o2::pid::tof::TOFResoParamsV2' has no member named 'getShift'; did you mean 'getTimeShift'?
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio force-pushed the nj-tofpid branch 2 times, most recently from 3d91be9 to cbd2136 Compare June 7, 2024 07:23
@alibuild

alibuild commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for dc40dc1 at 2024-06-07 16:18:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:419:100: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:421:130: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
/sw/SOURCES/O2Physics/6410-slc7_x86-64/0/Common/Core/PID/PIDTOF.h:422:85: error: 'const class o2::pid::tof::TOFResoParamsV3' has no member named 'getShift'; did you mean 'getTimeShift'?
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio enabled auto-merge (squash) June 7, 2024 16:55
@njacazio njacazio merged commit a91be67 into AliceO2Group:master Jun 8, 2024
@njacazio njacazio deleted the nj-tofpid branch June 8, 2024 11:29
GiorgioAlbertoLucia pushed a commit to GiorgioAlbertoLucia/O2Physics that referenced this pull request Jul 9, 2024
@njacazio @GiorgioAlbertoLucia
[PID TOF] Realign naming before upgrade (AliceO2Group#6410)
44347de 
- add V3 of TOF Calib parameters
echizzal pushed a commit to echizzal/O2Physics that referenced this pull request Jul 18, 2024
@njacazio @echizzal
[PID TOF] Realign naming before upgrade (AliceO2Group#6410)
78dc226 
- add V3 of TOF Calib parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddobrigk ddobrigk ddobrigk approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njacazio @alibuild @ddobrigk