Skip to content

Adding DCA distributions of global tracks#7384

Merged
nzardosh merged 5 commits into
AliceO2Group:masterfrom
KotliarovAr:ch_jet_qa_task
Aug 26, 2024
Merged

Adding DCA distributions of global tracks#7384
nzardosh merged 5 commits into
AliceO2Group:masterfrom
KotliarovAr:ch_jet_qa_task

Conversation

@KotliarovAr

Copy link
Copy Markdown
Contributor

Check the dcaX, dcaY, and dcaZ distributions of global tracks with number in ITS layers >= 4.

These histograms were suggested for checking to investigate the problem of the azimuthal distribution of high-pT global tracks.

@KotliarovAr

Copy link
Copy Markdown
Contributor Author

@fkrizek Could you take a look at the code? if you agree with the changes, we can proceed with the merging to the master branch

fkrizek
fkrizek previously approved these changes Aug 22, 2024
@KotliarovAr KotliarovAr marked this pull request as ready for review August 22, 2024 09:21
fkrizek
fkrizek previously approved these changes Aug 23, 2024
Comment thread PWGJE/Tasks/ChJetTriggerQATask.cxx Outdated

auto const& originalTrack = trk.track_as<soa::Join<aod::Tracks, aod::TracksExtra>>();
spectra.fill(HIST("globalP_tpcglobalPDiff_withoutcuts"), trk.p(), trk.p() - originalTrack.tpcInnerParam());
auto const& originalTrack = track.track_as<soa::Join<aod::Tracks, aod::TracksExtra>>();

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this break now when you run it? You are not subscribing to this table anymore. You should just remove originalTrack, you dont need it anymore

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code compiles, but I cannot perform local tests due to this issue:
'DPL internal error - oldestPossibleOutput decreased from 1 to 0'

Vit reported this issue 2 months ago; I contacted him, and he said he did not receive a response from the developers.

I am not sure that I got your idea correctly. To which table do you point? We use 'originalTrack' variable to get extra track information, for instance, 'tpcInnerParam()' and 'itsNCls()' which are not defined in our jet-track tables.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you process function is not subscribing to this table : soa::Join<aod::Tracks, aod::TracksExtra>
So it will break when you run it

@nzardosh nzardosh Aug 23, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add soa::Join<aod::Tracks, aod::TracksExtra> const& to the end of your process function

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add soa::Join<aod::Tracks, aod::TracksExtra> const& to the end of your process function

Thanks, fixed with the new commit

@nzardosh nzardosh self-requested a review August 23, 2024 16:16
@nzardosh nzardosh enabled auto-merge (squash) August 23, 2024 16:16
@nzardosh nzardosh disabled auto-merge August 23, 2024 16:41
@nzardosh nzardosh enabled auto-merge (squash) August 23, 2024 18:45
@KotliarovAr KotliarovAr changed the title [WIP] Adding DCA distributions of global tracks Adding DCA distributions of global tracks Aug 26, 2024
@nzardosh nzardosh merged commit f5d38ed into AliceO2Group:master Aug 26, 2024
joonsukbae pushed a commit to joonsukbae/O2Physics that referenced this pull request Aug 27, 2024
* Adding DCA distributions of global tracks

* Adding DCA distributions of global tracks

* Fixes according to update of PR AliceO2Group#7381

* Fixed process function arguments
fchinu pushed a commit to fchinu/O2Physics that referenced this pull request Sep 18, 2024
* Adding DCA distributions of global tracks

* Adding DCA distributions of global tracks

* Fixes according to update of PR AliceO2Group#7381

* Fixed process function arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants