Skip to content

[DPG] align QA tasks #7651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 3 commits into from
Sep 12, 2024
Merged

[DPG] align QA tasks #7651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd22430
[DPG] align QA tasks
njacazio Sep 11, 2024
9016528
Please consider the following formatting changes
alibuild Sep 11, 2024
e5b6a8a
Merge pull request #41 from alibuild/alibot-cleanup-7651
njacazio Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include <TTree.h>

using namespace o2;
using namespace o2::framework;
using namespace o2::framework::expressions;
Expand Down
5 changes: 2 additions & 3 deletions DPG/Tasks/AOTTrack/PID/TOF/qaPIDTOFEvTime.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,13 +455,12 @@ struct tofPidCollisionTimeQa {
continue;
}
const auto& collisionMC = collision.mcCollision_as<aod::McCollisions>();
const int64_t bcMCtime = static_cast<int64_t>((collisionMC.t() + 2.f) / o2::constants::lhc::LHCBunchSpacingNS);
const float eventtimeMC = (collisionMC.t() - bcMCtime * o2::constants::lhc::LHCBunchSpacingNS) * 1000.f;
const float eventtimeMC = collisionMC.t() * 1000.f;

if (trk.has_mcParticle()) {
const auto& particle = trk.mcParticle();
const auto& mcCollTimeMinusFormationTime = particle.vt() - collisionMC.t();
const auto& mcTOFvalue = trk.tofSignal() - eventtimeMC - trk.tofExpTime(2);
const auto& mcTOFvalue = trk.tofSignal() - eventtimeMC - trk.tofExpTimePi();
LOG(debug) << "Track " << particle.vt() << " vs " << eventtimeMC;
switch (particle.pdgCode()) {
case 211:
Expand Down
4 changes: 2 additions & 2 deletions DPG/Tasks/AOTTrack/PID/TPC/qaPIDTPCSignal.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ struct tpcPidQaSignal {
void processNoEvSel(soa::Filtered<TrackCandidates> const& tracks, aod::Collisions const& collisions)
{
histos.fill(HIST("event/evsel"), 1, collisions.size());
LOG(info) << "Processing " << collisions.size() << " collisions with " << tracks.size() << " tracks";
LOG(debug) << "Processing " << collisions.size() << " collisions with " << tracks.size() << " tracks";
processTracks(tracks);
}
PROCESS_SWITCH(tpcPidQaSignal, processNoEvSel, "Process without event selection", true);
Expand All @@ -290,7 +290,7 @@ struct tpcPidQaSignal {
void processMoreTrkSel(soa::Filtered<soa::Join<aod::TrackSelection, TrackCandidates>> const& tracks, aod::Collisions const& collisions)
{
histos.fill(HIST("event/evsel"), 1, collisions.size());
LOG(info) << "Processing " << collisions.size() << " collisions with " << tracks.size() << " tracks";
LOG(debug) << "Processing " << collisions.size() << " collisions with " << tracks.size() << " tracks";
processTracks(tracks);
}
PROCESS_SWITCH(tpcPidQaSignal, processMoreTrkSel, "Process without event selection", false);
Expand Down
7 changes: 4 additions & 3 deletions DPG/Tasks/AOTTrack/qaDcaMC.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ struct QaDcaMc {
ConfigurableAxis etaBins{"etaBins", {200, -3.f, 3.f}, "Eta binning"};
ConfigurableAxis phiBins{"phiBins", {200, 0.f, 6.284f}, "Phi binning"};
ConfigurableAxis yBins{"yBins", {200, -0.5f, 0.5f}, "Y binning"};
ConfigurableAxis dcaBins{"dcaBins", {2000, -1.f, 1.f}, "DCA binning"};
ConfigurableAxis dcaBinsxy{"dcaBinsxy", {500, -1.f, 1.f}, "DCAxy binning"};
ConfigurableAxis dcaBinsz{"dcaBinsz", {100, -0.1f, 0.1f}, "DCAz binning"};
Configurable<bool> doPVContributorCut{"doPVContributorCut", false, "Select tracks used for primary vertex recostruction (isPVContributor)"};

// Histograms
Expand Down Expand Up @@ -149,8 +150,8 @@ struct QaDcaMc {
const AxisSpec axisEta{etaBins, "#it{#eta}"};
const AxisSpec axisY{yBins, "#it{y}"};
const AxisSpec axisPhi{phiBins, "#it{#varphi} (rad)"};
const AxisSpec axisDCAxy{dcaBins, "DCA_{xy} (cm)"};
const AxisSpec axisDCAz{dcaBins, "DCA_{z} (cm)"};
const AxisSpec axisDCAxy{dcaBinsxy, "DCA_{xy} (cm)"};
const AxisSpec axisDCAz{dcaBinsz, "DCA_{z} (cm)"};

const char* partName = particleName(pdgSign, id);
LOG(info) << "Preparing histograms for particle: " << partName << " pdgSign " << pdgSign;
Expand Down
1 change: 0 additions & 1 deletion DPG/Tasks/AOTTrack/qaFakeHits.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ struct QaFakeHits {
const int histogramIndex = id + pdgSign * nSpecies;

const TString tagPt = Form("%s ", partName);

hPtAll[histogramIndex] = histos.add<TH1>(Form("MC/pdg%i/pt/all", PDGs[histogramIndex]), "All tracks " + tagPt, kTH1D, {axisPt});
hPtITS[histogramIndex] = histos.add<TH1>(Form("MC/pdg%i/pt/mismatched/its", PDGs[histogramIndex]), "ITS mismatch " + tagPt, kTH1D, {axisPt});
hPtTPC[histogramIndex] = histos.add<TH1>(Form("MC/pdg%i/pt/mismatched/tpc", PDGs[histogramIndex]), "TPC mismatch " + tagPt, kTH1D, {axisPt});
Expand Down