feat: scaffold @altimateai/mcp-data-agent (20 tool stubs)#826
Draft
anandgupta42 wants to merge 1 commit into
Draft
feat: scaffold @altimateai/mcp-data-agent (20 tool stubs)#826anandgupta42 wants to merge 1 commit into
anandgupta42 wants to merge 1 commit into
Conversation
Adds packages/mcp-data-agent/ — a stdio MCP server that will expose 20 curated SQL, dbt, FinOps, lineage, and PII tools from altimate-engine over the Model Context Protocol. Per docs/internal/2026-05-21-claude-code-plugin-mcp-spec.md. This is the contract surface only: - MCP server scaffolded with @modelcontextprotocol/sdk@^1.29.0 over stdio - 20 tool files, each declaring its zod input schema, description, and mutating/read-only annotation. Every handler currently throws NotImplementedError pointing at a tracking issue placeholder - Write gate: mutating tools (sql_execute, dbt_run) refuse to run unless ALTIMATE_MCP_ALLOW_WRITE=true. The refusal happens before the handler, so the "not implemented" stub is unreachable in read-only mode - bin/altimate-mcp shim mirrors the dbt-tools pattern - server.json manifest for the official MCP registry submission - Smoke tests: registry exports 20 tools, names are unique, tools/list over an in-memory MCP transport returns all 20, tools/call returns a not-implemented error for read tools, mutating tools refuse without the env gate - Workspace registration: packages/mcp-data-agent added to root package.json workspaces Local validation: - bun --cwd packages/mcp-data-agent run typecheck: pass - bun --cwd packages/mcp-data-agent test: 5/5 pass - bun build src/index.ts: produces dist/index.js - node bin/altimate-mcp over stdio: tools/list returns 20 tools - bun run script/upstream/analyze.ts --markers --base main --strict: pass (no upstream-shared files touched) Wiring tool handlers to altimate-engine is a separate workstream.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Scaffolds a new package
@altimateai/mcp-data-agent— a stdio MCP server that will expose 20 curated data-engineering tools (SQL, dbt, FinOps, lineage, PII) from altimate-engine to MCP-aware clients (Claude Code, Cursor, Windsurf, Goose, Cline, Claude Desktop).This is the scaffolding pass: package layout, MCP server boilerplate, 20 tool stubs that declare their schema but throw "not yet wired to altimate-engine." A buildable, typecheck-passing, test-passing contract surface ready for the next pass to wire each tool to its altimate-engine handler.
Why now: Part of the workflow-agents distribution plan documented in
docs/internal/2026-05-21-claude-code-plugin-mcp-spec.md. This package is the artifact behind:Both surfaces consume this package via
npx @altimateai/mcp-data-agent@latest.What this PR is not:
AltimateAI/altimate-code-data-agentis separate, ships next)Type of change
Issue for this PR
Tracking work from the workflow-agents pivot (
docs/internal/2026-05-18-workflow-agents-pivot.md) and the plugin spec (docs/internal/2026-05-21-claude-code-plugin-mcp-spec.md). No specific issue — this is foundational scaffolding for the distribution plan.How did you verify your code works?
bun --cwd packages/mcp-data-agent run typecheck— passes, zero errorsbun --cwd packages/mcp-data-agent test— 5/5 pass, 27 expect() callstools/listtools/callALTIMATE_MCP_ALLOW_WRITEunsetbun buildproducesdist/index.js(~1MB bundled)node bin/altimate-mcpwith hand-written JSON-RPC frames): server initializes,tools/listreturns 20 tools, write-gated tool refuses correctlybun run script/upstream/analyze.ts --markers --base main --strict): passes — no upstream-shared files touchedChecklist
/consensus:code-reviewrun (pending — will mark ready after)Files added (28):
package.json,tsconfig.json,server.json,README.md,.gitignorebin/altimate-mcp,src/index.ts,src/server.ts,src/auth.tssrc/tools/index.ts+ 20 tool stubs (sql_execute, sql_analyze, sql_explain, schema_introspect, dbt_compile, dbt_run, dbt_test, dbt_lineage, dbt_impact_analyze, dbt_diff, finops_credits_summary, finops_expensive_queries, finops_warehouse_advice, finops_unused_resources, finops_anomaly_scan, finops_clustering_roi, query_history_search, pii_scan, data_parity_check, account_usage_query)test/server.test.tsWorkspace changes:
package.json— addedpackages/mcp-data-agentto workspacesbun.lock— picked up new workspace +@modelcontextprotocol/sdk@^1.29.0Summary by cubic
Scaffolded
@altimateai/mcp-data-agent, a stdio MCP server that will expose 20 data-engineering tools (SQL, dbt, FinOps, lineage, PII). This pass adds server boilerplate and typed tool stubs with a write gate; wiring to altimate-engine comes next.New Features
@altimateai/mcp-data-agentwith an MCP stdio server.ALTIMATE_MCP_ALLOW_WRITE.server.jsonfor MCP registry andbin/altimate-mcpentrypoint.Dependencies
@modelcontextprotocol/sdk@^1.29.0.Written for commit 5fde8c7. Summary will update on new commits. Review in cubic