Skip to content

feat: scaffold @altimateai/mcp-data-agent (20 tool stubs)#826

Draft
anandgupta42 wants to merge 1 commit into
mainfrom
feat/mcp-data-agent
Draft

feat: scaffold @altimateai/mcp-data-agent (20 tool stubs)#826
anandgupta42 wants to merge 1 commit into
mainfrom
feat/mcp-data-agent

Conversation

@anandgupta42
Copy link
Copy Markdown
Contributor

@anandgupta42 anandgupta42 commented May 22, 2026

What does this PR do?

Scaffolds a new package @altimateai/mcp-data-agent — a stdio MCP server that will expose 20 curated data-engineering tools (SQL, dbt, FinOps, lineage, PII) from altimate-engine to MCP-aware clients (Claude Code, Cursor, Windsurf, Goose, Cline, Claude Desktop).

This is the scaffolding pass: package layout, MCP server boilerplate, 20 tool stubs that declare their schema but throw "not yet wired to altimate-engine." A buildable, typecheck-passing, test-passing contract surface ready for the next pass to wire each tool to its altimate-engine handler.

Why now: Part of the workflow-agents distribution plan documented in docs/internal/2026-05-21-claude-code-plugin-mcp-spec.md. This package is the artifact behind:

  • Claude Code plugin marketplace submission (170k MAU surface, zero porting effort)
  • Official MCP Registry listing (Cursor / Windsurf / Goose / Cline discoverability)

Both surfaces consume this package via npx @altimateai/mcp-data-agent@latest.

What this PR is not:

  • Not the actual tool implementations (each tool stubbed with a "not yet wired" error)
  • Not the standalone plugin repo (AltimateAI/altimate-code-data-agent is separate, ships next)
  • Not the npm publish (separate step after sign-off)

Type of change

  • New feature (non-breaking change which adds functionality)

Issue for this PR

Tracking work from the workflow-agents pivot (docs/internal/2026-05-18-workflow-agents-pivot.md) and the plugin spec (docs/internal/2026-05-21-claude-code-plugin-mcp-spec.md). No specific issue — this is foundational scaffolding for the distribution plan.

How did you verify your code works?

  • bun --cwd packages/mcp-data-agent run typecheck — passes, zero errors
  • bun --cwd packages/mcp-data-agent test — 5/5 pass, 27 expect() calls
    • Registry holds exactly 20 tools
    • Tool names are unique
    • In-memory MCP transport returns 20 tools from tools/list
    • Read-only stub returns "not yet wired" via tools/call
    • Mutating tool refuses with write-gate error when ALTIMATE_MCP_ALLOW_WRITE unset
  • bun build produces dist/index.js (~1MB bundled)
  • End-to-end stdio smoke (real node bin/altimate-mcp with hand-written JSON-RPC frames): server initializes, tools/list returns 20 tools, write-gated tool refuses correctly
  • Marker check (bun run script/upstream/analyze.ts --markers --base main --strict): passes — no upstream-shared files touched

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective / my feature works
  • New and existing unit tests pass locally with my changes
  • Marker check passes (no upstream-shared files modified)
  • /consensus:code-review run (pending — will mark ready after)
  • npm publish (separate step, after sign-off)
  • MCP registry submission (separate step, after npm publish)

Files added (28):

  • Package: package.json, tsconfig.json, server.json, README.md, .gitignore
  • Entry: bin/altimate-mcp, src/index.ts, src/server.ts, src/auth.ts
  • Tools: src/tools/index.ts + 20 tool stubs (sql_execute, sql_analyze, sql_explain, schema_introspect, dbt_compile, dbt_run, dbt_test, dbt_lineage, dbt_impact_analyze, dbt_diff, finops_credits_summary, finops_expensive_queries, finops_warehouse_advice, finops_unused_resources, finops_anomaly_scan, finops_clustering_roi, query_history_search, pii_scan, data_parity_check, account_usage_query)
  • Test: test/server.test.ts

Workspace changes:

  • Root package.json — added packages/mcp-data-agent to workspaces
  • bun.lock — picked up new workspace + @modelcontextprotocol/sdk@^1.29.0

Summary by cubic

Scaffolded @altimateai/mcp-data-agent, a stdio MCP server that will expose 20 data-engineering tools (SQL, dbt, FinOps, lineage, PII). This pass adds server boilerplate and typed tool stubs with a write gate; wiring to altimate-engine comes next.

  • New Features

    • New package @altimateai/mcp-data-agent with an MCP stdio server.
    • 20 tool stubs with Zod input schemas; mutating tools gated by ALTIMATE_MCP_ALLOW_WRITE.
    • server.json for MCP registry and bin/altimate-mcp entrypoint.
    • Tests verify 20 tools are listed, names unique, stubs error as expected, and write gate is enforced.
  • Dependencies

    • Added @modelcontextprotocol/sdk@^1.29.0.
    • Added package to root workspaces.

Written for commit 5fde8c7. Summary will update on new commits. Review in cubic

Adds packages/mcp-data-agent/ — a stdio MCP server that will expose 20
curated SQL, dbt, FinOps, lineage, and PII tools from altimate-engine
over the Model Context Protocol. Per docs/internal/2026-05-21-claude-code-plugin-mcp-spec.md.

This is the contract surface only:

- MCP server scaffolded with @modelcontextprotocol/sdk@^1.29.0 over stdio
- 20 tool files, each declaring its zod input schema, description, and
  mutating/read-only annotation. Every handler currently throws
  NotImplementedError pointing at a tracking issue placeholder
- Write gate: mutating tools (sql_execute, dbt_run) refuse to run unless
  ALTIMATE_MCP_ALLOW_WRITE=true. The refusal happens before the handler,
  so the "not implemented" stub is unreachable in read-only mode
- bin/altimate-mcp shim mirrors the dbt-tools pattern
- server.json manifest for the official MCP registry submission
- Smoke tests: registry exports 20 tools, names are unique, tools/list
  over an in-memory MCP transport returns all 20, tools/call returns a
  not-implemented error for read tools, mutating tools refuse without
  the env gate
- Workspace registration: packages/mcp-data-agent added to root
  package.json workspaces

Local validation:

- bun --cwd packages/mcp-data-agent run typecheck: pass
- bun --cwd packages/mcp-data-agent test: 5/5 pass
- bun build src/index.ts: produces dist/index.js
- node bin/altimate-mcp over stdio: tools/list returns 20 tools
- bun run script/upstream/analyze.ts --markers --base main --strict: pass
  (no upstream-shared files touched)

Wiring tool handlers to altimate-engine is a separate workstream.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f150aaa5-4f3b-4c8c-a863-daade989e43e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/mcp-data-agent

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant