Instantiation without semicolons causes crash

[lrettig]

Calling new Class without parentheses in a function without semicolons seems to cause the compiler to crash.

Code sample: https://webassembly.studio/?f=w3e7cc0usm

Snippet:

class Foo {}

function add(x: i32, y: i32): i32 {
  var foo = new Foo
  return x + y
}

add(1, 2)

Try to build and you'll see the browser freeze. I get the same issue on the commandline:

<--- Last few GCs --->

[55172:0x102802a00]    15393 ms: Mark-sweep 1281.2 (1337.4) -> 1281.2 (1337.4) MB, 3052.1 / 0.0 ms  allocation failure GC in old space requested
[55172:0x102802a00]    18417 ms: Mark-sweep 1281.2 (1337.4) -> 1281.2 (1306.4) MB, 3024.0 / 0.0 ms  last resort
[55172:0x102802a00]    21426 ms: Mark-sweep 1281.2 (1306.4) -> 1281.2 (1306.4) MB, 3009.3 / 0.0 ms  last resort


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3b0b503a8799 <JSObject>
    1: /* anonymous */ [/Users/user/folder/ewasm-as-multisig/node_modules/assemblyscript/dist/assemblyscript.js:~1] [pc=0x1514097510fd](this=0x2392fb4c6959 <t map = 0x2f9686c8c1d9>,e=1109,t=2,r=0x12c46ede0719 <e map = 0x2f9686c8c7b1>,n=0x3f65f4882201 <null>,i=0x3f65f4882201 <null>,a=0x3f65f4882201 <null>)
    2: /* anonymous */ [/Users/user/folder/ewasm-as-multisig/node_modules/ass...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [/Users/user/.nvm/versions/node/v8.6.0/bin/node]
 2: node::FatalException(v8::Isolate*, v8::Local<v8::Value>, v8::Local<v8::Message>) [/Users/user/.nvm/versions/node/v8.6.0/bin/node]
 3: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/Users/user/.nvm/versions/node/v8.6.0/bin/node]
 4: v8::internal::Factory::NewUninitializedFixedArray(int) [/Users/user/.nvm/versions/node/v8.6.0/bin/node]
 5: v8::internal::(anonymous namespace)::ElementsAccessorBase<v8::internal::(anonymous namespace)::FastPackedObjectElementsAccessor, v8::internal::(anonymous namespace)::ElementsKindTraits<(v8::internal::ElementsKind)2> >::GrowCapacity(v8::internal::Handle<v8::internal::JSObject>, unsigned int) [/Users/user/.nvm/versions/node/v8.6.0/bin/node]
 6: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [/Users/user/.nvm/versions/node/v8.6.0/bin/node]
 7: 0x1514095846fd
sh: line 1: 55021 Abort trap: 6           npm run asbuild:untouched

[dcodeIO]

With master, on the command line I get:

ERROR AS100: Operation not supported.

   var foo = new Foo
                 ~~~

Anything else I need to know to reproduce?

[lrettig]

Do you see the freezing behavior I described in WebAssembly studio? Try to build this: https://webassembly.studio/?f=w3e7cc0usm

[dcodeIO]

Yes, I am also seeing the freezing behavior there. Actually, there have been a few issues lately that worked on the command line but not in WASM studio, so that'll require some investigation as well.

Reminds me of the "\r\n" vs "\n" line ending thing we saw a while ago, with just "\n" sometimes leading to an infinite loop somewhere.

[lrettig]

Strange. When I simply npm install AssemblyScript/assemblyscript I encounter this issue. When I instead manually checkout the repo and npm link it, I don't. I assumed this would do the same thing.

[dcodeIO]

When saving the source file with "\n" line endings, it results in an infinite loop on the command line as well.

[dcodeIO]

That should, theoretically, fix the rogue crash.

[lrettig]

Thanks, I'll give this a try

[lrettig]

I'm still seeing the infinite loop using the most recent commit:

> grep assemblyscript package-lock.json
    "assemblyscript": {
      "version": "github:AssemblyScript/assemblyscript#585d2461657ffd9a82688c0a0f620e3a7e748767",
      "from": "github:AssemblyScript/assemblyscript",

[lrettig]

When I npm install from github, I get the infinite loop. When I npm link against a local repo, I don't get an infinite loop but it cannot find the stdlib:

> npm link assemblyscript
> ls -la node_modules/assemblyscript/std
ls: node_modules/assemblyscript/std: No such file or directory
> npm install --save-dev AssemblyScript/assemblyscript
npm WARN ewasm-as-multisig No description
npm WARN ewasm-as-multisig No repository field.
npm WARN ewasm-as-multisig No license field.

+ assemblyscript@0.5.0
updated 1 package and audited 18 packages in 17.385s
found 0 vulnerabilities

> ls -la node_modules/assemblyscript/std
total 24
drwxr-xr-x   8 lanerettig  staff  256 Jul 10 18:46 .
drwxr-xr-x  15 lanerettig  staff  480 Jul 10 18:46 ..
-rw-r--r--   1 lanerettig  staff  188 Oct 26  1985 README.md
drwxr-xr-x  22 lanerettig  staff  704 Jul 10 18:46 assembly
-rw-r--r--   1 lanerettig  staff  218 Oct 26  1985 assembly.json
drwxr-xr-x   5 lanerettig  staff  160 Jul 10 18:46 portable
-rw-r--r--   1 lanerettig  staff  278 Oct 26  1985 portable.json
drwxr-xr-x   4 lanerettig  staff  128 Jul 10 18:46 types

[MaxGraey]

@lrettig In WAS works fine after latest fixes: https://webassembly.studio/?f=w3e7cc0usm

[lrettig]

The full code is here, in case it compiles for you! https://github.com/lrettig/ewasm-as-multisig

[MaxGraey]

btw this doesn't support yet.

[lrettig]

No problem. The super call doesn't do anything yet but I added it because I was getting this error:

 31   constructor(
      ~~~~~~~~~~~~
 32     owners: Address[],
    ~~~~~~~~~~~~~~~~~~~~~~
...
 42     write<Set>("isOwner", isOwner)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 43   }
    ~~~

assembly/index.ts(31,3): error TS2377: Constructors for derived classes must contain a 'super' call.