Skip to content

update ts-node to 8.6.2#1168

Closed
MaxGraey wants to merge 1 commit into
AssemblyScript:masterfrom
MaxGraey:update-ts-node
Closed

update ts-node to 8.6.2#1168
MaxGraey wants to merge 1 commit into
AssemblyScript:masterfrom
MaxGraey:update-ts-node

Conversation

@MaxGraey

Copy link
Copy Markdown
Member

@MaxGraey

Copy link
Copy Markdown
Member Author

btw ts-node was included in devDependencies and dependencies

@MaxGraey MaxGraey requested a review from dcodeIO March 14, 2020 06:55
@dcodeIO

dcodeIO commented Mar 14, 2020

Copy link
Copy Markdown
Member

update ts-node to 8.6.2

Last time i checked upgrading to >6 led to subtle errors as described here. Wondering if that's not an issue anymore?

btw ts-node was included in devDependencies and dependencies

The duplicates are intentional as an indicator that these are needed on npm install AssemblyScript/assemblyscript, but not on npm install assemblyscript. Handled by prepublish.

@MaxGraey

Copy link
Copy Markdown
Member Author

Last time i checked upgrading to >6 led to subtle errors as described here.

Not sure, but you could check this. I didn't see any errors

@dcodeIO dcodeIO mentioned this pull request Mar 14, 2020
@dcodeIO

dcodeIO commented Mar 14, 2020

Copy link
Copy Markdown
Member

Fixed by #1170

@dcodeIO dcodeIO closed this Mar 14, 2020
@MaxGraey MaxGraey deleted the update-ts-node branch March 15, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants