Skip to content

Respect absolute output paths#1217

Merged
dcodeIO merged 4 commits into
AssemblyScript:masterfrom
surma-dump:fix-1215
Apr 12, 2020
Merged

Respect absolute output paths#1217
dcodeIO merged 4 commits into
AssemblyScript:masterfrom
surma-dump:fix-1215

Conversation

@surma

@surma surma commented Apr 12, 2020

Copy link
Copy Markdown
Contributor

I wanted to test #1216, but it turned out it was a bit more complicated. Thought I’d get my hands dirty rather than stretching this out any further. Hope you don’t mind, @MaxGraey.

Fixes #1215

@MaxGraey

Copy link
Copy Markdown
Member

You should add yourself to NOTICE file

@dcodeIO

dcodeIO commented Apr 12, 2020

Copy link
Copy Markdown
Member

Guess who immediately anticipated having to fix CI again

@surma

surma commented Apr 12, 2020

Copy link
Copy Markdown
Contributor Author

😅 done

@dcodeIO dcodeIO left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the very serious bureaucracy problem where you give us some of your data so we can name you in our frequent legal activities has been corrected, LGTM.

@surma

surma commented Apr 12, 2020

Copy link
Copy Markdown
Contributor Author

Looking forward to make lawsuits part of my regular schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

asc does not respect absolute output paths

3 participants