Skip to content

fix: use favicon as default plugin icon - #9547

Open
wcqqq1214 wants to merge 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/dashboard-default-plugin-icon-favicon
Open

fix: use favicon as default plugin icon#9547
wcqqq1214 wants to merge 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/dashboard-default-plugin-icon-favicon

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Modifications / 改动点

The default placeholder icon for plugins still used the legacy plugin_icon.png after AstrBot switched to the current blue-star logo. This change points the default plugin icon at the official favicon (/favicon.svg) for plugins that do not ship their own logo.png.

  • Core files modified (one-line change each, import defaultPluginIcon from "@/assets/images/plugin_icon.png"import defaultPluginIcon from "/favicon.svg"):

    • dashboard/src/components/shared/ExtensionCard.vue
    • dashboard/src/views/ExtensionPage.vue
    • dashboard/src/views/extension/MarketPluginsTab.vue
    • dashboard/src/views/extension/PluginDetailPage.vue
  • No related issue — this is a small, self-contained fix, so no issue was filed.

  • Note: the old asset dashboard/src/assets/images/plugin_icon.png has not been deleted; it is still used as the brand logo in Logo.vue and SetupPage.vue.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

Before / 修复前:

Screenshot 2026-08-04 at 18 43 44

After / 修复后:

Screenshot 2026-08-04 at 18 28 35

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了"验证步骤"和"运行截图"

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Correct the fallback plugin icon to reference the current favicon instead of the legacy plugin_icon asset.

Summary by Sourcery

Bug Fixes:

  • Correct fallback plugin icons across extension-related views to reference the current favicon instead of the legacy plugin icon asset.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review August 4, 2026 11:20
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:webui The bug / feature is about webui(dashboard) of astrbot. labels Aug 4, 2026
@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about AstrBot Add Dosu to your team

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • You’re now hardcoding the same defaultPluginIcon import in four places; consider centralizing this (e.g., a shared constant or composable) so updates to the default icon only have to be done in one file.
  • Importing /favicon.svg via ES module syntax may behave differently across bundlers/environments; it might be more robust to reference the public URL directly in templates or via a shared config rather than treating it as a bundled asset.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- You’re now hardcoding the same `defaultPluginIcon` import in four places; consider centralizing this (e.g., a shared constant or composable) so updates to the default icon only have to be done in one file.
- Importing `/favicon.svg` via ES module syntax may behave differently across bundlers/environments; it might be more robust to reference the public URL directly in templates or via a shared config rather than treating it as a bundled asset.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webui The bug / feature is about webui(dashboard) of astrbot. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant