fix: use favicon as default plugin icon - #9547
Open
wcqqq1214 wants to merge 1 commit into
Open
Conversation
wcqqq1214
marked this pull request as ready for review
August 4, 2026 11:20
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- You’re now hardcoding the same
defaultPluginIconimport in four places; consider centralizing this (e.g., a shared constant or composable) so updates to the default icon only have to be done in one file. - Importing
/favicon.svgvia ES module syntax may behave differently across bundlers/environments; it might be more robust to reference the public URL directly in templates or via a shared config rather than treating it as a bundled asset.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You’re now hardcoding the same `defaultPluginIcon` import in four places; consider centralizing this (e.g., a shared constant or composable) so updates to the default icon only have to be done in one file.
- Importing `/favicon.svg` via ES module syntax may behave differently across bundlers/environments; it might be more robust to reference the public URL directly in templates or via a shared config rather than treating it as a bundled asset.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications / 改动点
The default placeholder icon for plugins still used the legacy
plugin_icon.pngafter AstrBot switched to the current blue-star logo. This change points the default plugin icon at the official favicon (/favicon.svg) for plugins that do not ship their ownlogo.png.Core files modified (one-line change each,
import defaultPluginIcon from "@/assets/images/plugin_icon.png"→import defaultPluginIcon from "/favicon.svg"):dashboard/src/components/shared/ExtensionCard.vuedashboard/src/views/ExtensionPage.vuedashboard/src/views/extension/MarketPluginsTab.vuedashboard/src/views/extension/PluginDetailPage.vueNo related issue — this is a small, self-contained fix, so no issue was filed.
Note: the old asset
dashboard/src/assets/images/plugin_icon.pnghas not been deleted; it is still used as the brand logo inLogo.vueandSetupPage.vue.This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Before / 修复前:
After / 修复后:
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了"验证步骤"和"运行截图"。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Bug Fixes: