Skip to content

Add BurnBothEnds strategy#1410

Merged
marcharper merged 1 commit into
devfrom
bbe
Mar 16, 2023
Merged

Add BurnBothEnds strategy#1410
marcharper merged 1 commit into
devfrom
bbe

Conversation

@marcharper

@marcharper marcharper commented Feb 19, 2023

Copy link
Copy Markdown
Member

Tests pass locally, seems black wants to reformat a large number of files. I suggest doing that in a separate PR afterward.

@Nikoleta-v3 Nikoleta-v3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻 Thank you @marcharper

@marcharper

Copy link
Copy Markdown
Member Author

@drvinceknight PTAL

@drvinceknight

Copy link
Copy Markdown
Member

It's failing on black due to an upstream update of black.

We have not pinned a version of black which is installed in the CI here https://github.com/Axelrod-Python/Axelrod/blob/dev/.github/workflows/config.yml#L58.

Two solutions:

  1. Pin black in config.yml. (arguably we could move a few of the installs in that config file to requirements/development.txt?).
  2. Update black and run it again over the whole code base.

I'm agnostic: whatever you prefer Marc :)

@marcharper

Copy link
Copy Markdown
Member Author

I'm fine either way. We can pin black in another PR (do you know the version?) but if we're going to rerun black on the entire codebase, let's merge this first.

@drvinceknight

Copy link
Copy Markdown
Member

Sounds good to me.

Checking black locally:

(base) Axelrod(dev): python -m black -l 80 . --check
All done! ✨ 🍰 ✨
186 files would be left unchanged.
(base) Axelrod(dev): python -m pip show black
Name: black
Version: 22.10.0
Summary: The uncompromising code formatter.
Home-page: None
Author: None
Author-email: Łukasz Langa <lukasz@langa.pl>
License: None
Location: /Users/four/anaconda3/lib/python3.8/site-packages
Requires: mypy-extensions, tomli, platformdirs, typing-extensions, pathspec, click
Required-by:
(base) Axelrod(dev):

So as far as I can tell 22.10.0 should do the trick. So changing https://github.com/Axelrod-Python/Axelrod/blob/dev/.github/workflows/config.yml#L58 to:

python -m pip install black=="22.10.0"

Should work.

@marcharper

Copy link
Copy Markdown
Member Author

Merging, opened #1412 to pin black version.

@marcharper marcharper merged commit 28f4265 into dev Mar 16, 2023
@marcharper marcharper deleted the bbe branch March 8, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants