Forward port async fix (from old-name-support)#15
Merged
Conversation
… more complete fix may not be feasible..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a recent Paper change means that duplicate events for PlayerCommandSendEvent are now received, some of which are Async.
This fix is only to avoid errors, it doesn not add support for async command list events - the impacts are not yet well known.
Since this plugin needs to checks users permissions, there may not be a good fix (aside from elaborately scheduling tasks to precache permissions on a sync thread - but what do you do when there is a cache miss?)