[Pipeline] Users/seseicht/adjust publish - #1472
Merged
Marius Storhaug (MariusStorhaug) merged 14 commits intoJun 26, 2022
Merged
[Pipeline] Users/seseicht/adjust publish#1472Marius Storhaug (MariusStorhaug) merged 14 commits into
Marius Storhaug (MariusStorhaug) merged 14 commits into
Conversation
This reverts commit adf1c64.
…eicht/ResourceModules into users/seseicht/adjustPublish
Erika Gressi (eriqua)
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for introducing this new feature, very much needed. A couple of comments from my side:
- Discuss if the same SP should have permissions on both validation and publish subscription or if we need to support 2 different SP/serviceConnections as well. This is often the case with customers requiring an SP to be mapped to a specific subscription
- If going with supporting 2 SP this PR will closely relate to PR #1452 (see also comment to issue #1465)
- Additional documentation needed and depending on the 2 points above
Erika Gressi (eriqua)
left a comment
Contributor
There was a problem hiding this comment.
Converted to draft to be merged after publishing the next release and after team agreement on all secret names
Erika Gressi (eriqua)
marked this pull request as draft
June 14, 2022 08:04
Marius Storhaug (MariusStorhaug)
changed the base branch from
main
to
issue/1607
June 26, 2022 13:48
Marius Storhaug (MariusStorhaug)
marked this pull request as ready for review
June 26, 2022 13:50
Contributor
|
Merging to a full implementation branch for 'overhauling' authentication |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1085
These change will allow to publish the artifacts in a different subscripion than the validation modules.
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist