Skip to content

[AutoPR azure-resourcemanager-network]-generated-from-SDK Generation - Java-6702249 - #50141

Open
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-resourcemanager-network-6702249
Open

[AutoPR azure-resourcemanager-network]-generated-from-SDK Generation - Java-6702249#50141
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-resourcemanager-network-6702249

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/network/resource-manager/Microsoft.Network/Network/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'bd92126f09e7e3caa74f10fa1c944d1e451813ac' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6702249 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36026 Submitted by: v-slokar@microsoft.com

…work/Network/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'bd92126f09e7e3caa74f10fa1c944d1e451813ac' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6702249 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI lite review requested due to automatic review settings August 14, 2026 04:39
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Aug 14, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
35 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

Copy link
Copy Markdown
Contributor

Automated management AutoPR review

  • Head SHA: f799eab
  • Package: azure-resourcemanager-network 2.60.0
  • Release type: stable
  • API version: 2025-09-01, 2018-10-01
  • CHANGELOG: 2.60.0 (2026-08-14)
  • Java changes reviewed: 18 added and 78 modified non-generated Java files in sdk/network/azure-resourcemanager-network
  • Breaking changes: none
  • Decision: no high-confidence concerns

Informational

  • MGMT-API-VERSION New — sdk/network/azure-resourcemanager-network/CHANGELOG.md, release 2.60.0 (2026-08-14), records effective API versions 2025-09-01 and 2018-10-01.

Automated management AutoPR review by Management AutoPR Review: https://github.com/Azure/azure-sdk-for-java/actions/runs/31770524298. Advisory only.

@weidongxu-microsoft

Copy link
Copy Markdown
Member

The generated stable release changes the public contract of the existing ServiceGatewaysClient operations updateAddressLocations and updateServices compared with released version 2.59.1:

  • The beginUpdateAddressLocations* and beginUpdateServices* LRO methods are removed.
  • Existing methods change from void / Mono<Void> / Response<Flux<ByteBuffer>> to ServiceGatewayActionOkResponseBodyInner response types.
  • The CHANGELOG does not document these breaking changes.

This looks like an LRO/response-model change originating from the specification. Could you please confirm whether the operations are intended to change from long-running to synchronous and address compatibility for this stable release?

The duplicate AutoPR has equivalent generated code; the only difference is ordering of three CHANGELOG bullet pairs.

* @return empty success response on successful completion of {@link Mono}.
*/
@ServiceMethod(returns = ReturnType.LONG_RUNNING_OPERATION)
PollerFlux<PollResult<Void>, Void> beginUpdateAddressLocationsAsync(String resourceGroupName,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? The API was LRO, but now change to simple operation?

@weidongxu-microsoft Weidong Xu (weidongxu-microsoft) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weidongxu-microsoft

Copy link
Copy Markdown
Member

The LRO-to-synchronous change is intentional and originates from Azure/azure-rest-api-specs#44745.

That PR confirms UpdateSgwLocationAddress and UpdateSgwServices return immediately rather than behaving as LROs. The versioned TypeSpec preserves the LRO shape for older API versions and introduces synchronous operations for 2025-09-01:

https://github.com/Azure/azure-rest-api-specs/blob/bd92126f09e7e3caa74f10fa1c944d1e451813ac/specification/network/resource-manager/Microsoft.Network/Network/Network/ServiceGateway.tsp#L128-L196

Given that service/spec context, the generated API change is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants