Reenable logging stacktraces of uncaught exceptions#108
Merged
Conversation
JelteF
requested review from
Aniruddh25,
Mathos1432,
jarupatj,
mbhaskar,
moderakh and
seantleonard
as code owners
JelteF
force-pushed
the
log-uncaught-exceptions
branch
from
22dffbd to
57a11ad
Compare
Logging of stacktraces was disabled by #97. Based on PR comments the reason for this was that for most types of errors `error.Exception` would be `null`. Thus the exception logging code would actually create a new error by dereferencing a `null`. This was addressed by only logging the error `Code` and `Message`. However, logging these is not very useful. They are already passed to the frontend. So this fixes the problem in a better way, by only logging to stderr when the error its `error.Exception` field is non-null.
jarupatj
approved these changes
Nov 29, 2021
jarupatj
left a comment
jarupatj
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing this.
seantleonard
approved these changes
Nov 29, 2021
seantleonard
left a comment
seantleonard
left a comment
Contributor
There was a problem hiding this comment.
Looks good, properly see Error message and stacktrace in Console now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging of stacktraces was disabled by #97. Based on PR comments the
reason for this was that for most types of errors
error.Exceptionwould be
null. Thus the exception logging code would actually create anew error by dereferencing a
null.This was addressed by only logging the error
CodeandMessage.However, logging these is not very useful. They are already passed to
the frontend. So this fixes the problem in a better way, by only logging
to stderr when the error its
error.Exceptionfield is non-null.