Wildcard action support in config#577
Merged
Merged
Conversation
…ub.com/Azure/hawaii-gql into dev/agarwalayush/WildcardActionSupport
…s and combine the verifications in the same test.
…nWithExplicitColumnInclusion
aaronburtle
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com> Co-authored-by: aaronburtle <93220300+aaronburtle@users.noreply.github.com>
…ub.com/Azure/hawaii-gql into dev/agarwalayush/WildcardActionSupport
Aniruddh25
reviewed
Jul 20, 2022
Aniruddh25
reviewed
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this required?
This change is required to support wildcard (*) action in the config file for an enitity role combination. Previously, we used to get this error when we had wildcard as an action:
How was this done?
Whenever we get a wildcard action for an entity/role combination, we translate it into the 4 allowed CRUD operations i.e. create,read,update,delete. While setting the AuthorizationResolver.EntityPermissionMap, we include mappings for all the 4 operations instead of the wildcard operation.
How was this tested?
Included negative/positive tests for different authorization stages in AuthorizationResolverUnitTests.cs file where the wildcard is present as an action.