Use exposed names in Request Context OrderByColumns#690
Merged
Conversation
aaronburtle
commented
Aug 11, 2022
aaronburtle
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
seantleonard,
severussundar,
swviswan and
tarazou9
as code owners
Contributor
|
Need to have tests for this scenario. |
jarupatj
previously requested changes
Aug 11, 2022
ayush3797
reviewed
Aug 12, 2022
Aniruddh25
reviewed
Aug 15, 2022
Aniruddh25
reviewed
Aug 15, 2022
Aniruddh25
reviewed
Aug 16, 2022
Aniruddh25
reviewed
Aug 16, 2022
Aniruddh25
reviewed
Aug 16, 2022
Aniruddh25
reviewed
Aug 16, 2022
Aniruddh25
reviewed
Aug 22, 2022
Aniruddh25
reviewed
Aug 22, 2022
aaronburtle
dismissed
jarupatj’s stale review
Stale request, addressed changes, PR is blocking ayush
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix associated with this issue: #650
Authorization presumes we have exposed names in the request context. Currently we have backing column names in the OrderByColumns that are created for the request context. This change modifies the request parser so that we use the exposed names, allowing authorization to handle those columns without issue. We then add in a helper function to convert the exposed names of the columns to backing column names later when we form the sql query structure.