fix: close 16 defects from adversarial bug-hunt sweep - #128
Merged
Merged
Conversation
A reconnect during a delta firehose abandons the old client's Events channel with no reader; when the buffer was full, readLoop parked forever on its next send, leaking a goroutine and an MBs-scale buffer per drop. Close now closes a done channel and every Events send selects on it, so a closed client's readLoop always exits.
waitSpawned rendered %!w(<nil>) when a server died or timed out with no stderr tail, and dereferenced a nil scanner on the top-of-loop token check. The diagnostics tail also froze at the startup banner once the token was found, so a server that failed after printing it showed irrelevant output. The tail now follows all post-banner output (with partial-line buffering), and empty tails are omitted from the error.
reloadLocked merged only foreign additions, so a stale in-memory entry for a directory this instance was NOT saving republished dead drafts and session ids over a fresher on-disk state — e.g. a /new cleared by another bodek instance resurrected on this instance's next Save of any other cwd. The on-disk store now wins for every cwd except the one the caller is writing.
The bg_job handler returned a per-event fetch cmd, which ingestWireBatch discards — a push frame arriving with any other frame lost its immediate jobs snapshot and waited for the next watcher tick. The kick now rides the flushKicks flag like the agents/memory refreshes, coalescing into one fetch per burst.
- approvalSendErrMsg now restores the popped head's BEL latch with it, keeping apprBells 1:1 with apprDeadlines; the urgent window previously latched the wrong request for the rest of the session. - a mid-queue approval expiry repaints the form: the 'N queued' hint stayed stale up to the head's TTL when the head itself survived. - scheduleReconnect stamps each chain with a generation; a manual retry supersedes a pending backoff tick instead of racing it into two concurrent hook dials. Superseded outcomes drop (closing any socket).
- upgrade: the Windows aside-swap now rolls the old binary back when the install rename fails, instead of stranding the executable as .old. - upgrade: release-asset downloads use a per-request 10m deadline instead of inheriting the API client's overall 10s timeout, which cut every multi-MB transfer over a slow link. - upgrade: the new binary is fsynced before the rename, honoring the 'never leaves a truncated binary' contract on crash. - update: Go pseudo-version stamps (v0.1.3-0.2026...) compare by their release prefix, so commit-installed builds still see newer releases. - tui: reopening the jobs tab invalidates the in-flight tab tick, which used to pass the stale seq check and arm a second watcher chain.
- the rollback-fail path now tags its error (tmpKeptError) so the deferred temp cleanup keeps the staged new binary instead of deleting it — both halves survive for recovery. - pseudo-version detection anchors on '-0.' + a 14-digit timestamp so a genuine semver prerelease (1.2.0-0.1) is not misparsed. - slow-link test margins widened (300ms vs 2s) for CI stability.
- the error close-out now resets runCtxCum like done, so a failed run's pre-v2.3 cumulative cannot under-report the next run's ctx gauge. - a usage frame trailing a finalized turn no longer opens an orphan turn card (busy wedge): usage is telemetry — thinking/token frames keep the lazy-open fallback, so nothing drops. - regression tests for both, plus the stale-wakeArmed mid-turn case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four bug-hunt rounds, 16 validated defects fixed RED-first (each with a regression test):
Adversarial review passed (2 reviewers, no blockers/majors). Race suite 9/9 pkgs, vet clean, lint 0 issues.