Add tests for Parser class - #8
Merged
Merged
Conversation
Member
|
Mettre dans grumphp les tests aussi ? :) |
Member
Author
|
@Rahe j'y ai pensé, mais j'ai peur que ça ralentisse énormément le temps lors des commits. Je préfère plutôt laisser les développeurs exécuter la commande des tests avant de commiter pour s'assurer que tout est bon. Sachant que les tests tournent aussi sur les PR. |
petitphp
force-pushed
the
feat/parser-tests
branch
from
February 28, 2023 21:46
5b15bef to
77d670f
Compare
Member
|
Ok pas de problème :) |
Member
|
Du coup, on marge ce premier boilerplate ? |
Member
Author
|
J'ai encore une série de tests à push. Dès que c'est bon, je passerai la PR en review. |
petitphp
force-pushed
the
feat/parser-tests
branch
from
March 2, 2023 21:33
77d670f to
2d897b0
Compare
petitphp
marked this pull request as ready for review
March 2, 2023 21:33
Rahe
reviewed
Mar 3, 2023
| <p>Adipiscing at in tellus integer feugiat scelerisque varius morbi.</p> | ||
| <!-- /wp:paragraph --> | ||
|
|
||
| <!-- wp:paragraph {"sharedBlockId":"cc38bbdf-f161-459e-8242-b91cd9a5b73f","sharedBlockIsShared":true} --> |
Member
There was a problem hiding this comment.
Le sharedBlockId (cc38bbdf-f161-459e-8242-b91cd9a5b73f) à mettre dans une variable ? de quoi ne pas avoir de problématique du type mal copié/collé.
Rahe
approved these changes
Mar 3, 2023
Rahe
approved these changes
Mar 3, 2023
petitphp
force-pushed
the
feat/parser-tests
branch
4 times, most recently
from
March 7, 2023 21:51
56813d4 to
cb382cd
Compare
petitphp
force-pushed
the
feat/parser-tests
branch
from
March 7, 2023 21:56
cb382cd to
3d9e08b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.