Skip to content

feat(sol): warn when recovery is called without durable nonce (SIMD-525) #9372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhavidhingra wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

feat(sol): warn when recovery is called without durable nonce (SIMD-525) #9372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions modules/sdk-coin-sol/src/sol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,6 +1283,16 @@ export class Sol extends BaseCoin {
let totalFee = new BigNumber(0);
let totalFeeForTokenRecovery = new BigNumber(0);

// Warn if durable nonce is not provided for SOL recovery.
// With SIMD-525 (200ms slots), the blockhash validity window drops from ~60s to ~30s.
// Recovery flows that don't use durable nonce must complete build-sign-broadcast within that window.
if (!params.durableNonce) {
logger.warn(
'SOL recovery without durable nonce: transaction must be signed and broadcast within the blockhash validity window (~30s at 200ms slots). ' +
'Provide params.durableNonce for flows that may exceed this window.'
);
}

// check for possible token recovery, recover the token provide by user
if (params.tokenContractAddress) {
let isUnsupportedToken = false;
Expand Down
Loading