feat: filter safe key ceremonies by enabled root slots - #9374
Open
davidkaplanbitgo wants to merge 2 commits into
Open
feat: filter safe key ceremonies by enabled root slots#9374davidkaplanbitgo wants to merge 2 commits into
davidkaplanbitgo wants to merge 2 commits into
Conversation
Contributor
createSafeKeys now runs only the root-key ceremonies for slots the server enabled at initialize (enabledRootSlots), falling back to all 4 when absent for backwards compatibility with older WP. TICKET: WCN-1658
davidkaplanbitgo
changed the title
davidkaplanbitgo
marked this pull request as ready for review
July 28, 2026 20:00
Contributor
Author
|
This is failing due to a cooldown period. It is okay to review and then I will rerun CI once it is in |
danielpeng1
approved these changes
Jul 28, 2026
Marzooqa
approved these changes
Jul 29, 2026
OttoAllmendinger
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createSafeKeys now runs only the root-key ceremonies for slots the
server enabled at initialize (enabledRootSlots), falling back to all
4 when absent for backwards compatibility with older WP.
TICKET: WCN-1658