Feature: Migrate ping to live charts + add tooltip to speedtest#3449
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the Ping Monitor charting UI from LiveCharts (v0.9.x) to LiveCharts2 and introduces custom tooltip controls for the Ping Monitor and SpeedTest widget charts to improve in-chart value inspection.
Changes:
- Replaced Ping Monitor chart implementation (axes/series/tooltip) with LiveCharts2 equivalents.
- Added LiveCharts2 tooltip controls for Ping Monitor and SpeedTest charts, and wired them into the corresponding views.
- Updated shared chart data container
LvlChartsDefaultInfoto an immutable primary-constructor style.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Source/NETworkManager/Views/SpeedTestWidgetView.xaml | Adds LiveCharts2 tooltip to download/upload sparklines and adjusts layout containers. |
| Source/NETworkManager/Views/PingMonitorView.xaml | Swaps LiveCharts v1 chart for LiveCharts2 chart and hooks up the new tooltip control. |
| Source/NETworkManager/ViewModels/SpeedTestWidgetViewModel.cs | Tweaks LiveCharts2 series config (names/geometry) to support the new tooltip display. |
| Source/NETworkManager/ViewModels/PingMonitorViewModel.cs | Reimplements Ping time series + axes using LiveCharts2 and dynamic axis windowing. |
| Source/NETworkManager/Controls/LvlChartsPingTimeTooltip.xaml.cs | Removes legacy LiveCharts v1 tooltip code-behind. |
| Source/NETworkManager/Controls/LvlChartsPingTimeTooltip.xaml | Removes legacy LiveCharts v1 tooltip UI. |
| Source/NETworkManager/Controls/LiveChartsSpeedTestTooltip.xaml.cs | Adds a LiveCharts2 tooltip implementation for SpeedTest sparklines. |
| Source/NETworkManager/Controls/LiveChartsSpeedTestTooltip.xaml | Adds the tooltip UI for SpeedTest sparklines. |
| Source/NETworkManager/Controls/LiveChartsPingTimeTooltip.xaml.cs | Adds a LiveCharts2 tooltip implementation for Ping Monitor. |
| Source/NETworkManager/Controls/LiveChartsPingTimeTooltip.xaml | Adds the tooltip UI for Ping Monitor. |
| Source/NETworkManager.Utilities/LvlChartsDefaultInfo.cs | Makes the chart datapoint container immutable via primary constructor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+277
to
+281
| var chartColor = SKColor.Parse("#1ba1e2"); | ||
|
|
||
| var labelColor = Application.Current.Resources["MahApps.Brushes.Gray5"] is System.Windows.Media.SolidColorBrush gray5 | ||
| ? new SKColor(gray5.Color.R, gray5.Color.G, gray5.Color.B, gray5.Color.A) | ||
| : new SKColor(0x68, 0x68, 0x68); |
Contributor
There was a problem hiding this comment.
Fixed in 5d65242 by switching both resource lookups in InitialTimeChart() to Application.Current?.TryFindResource(...), which preserves the existing SKColor fallbacks when Application.Current/resources are unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
To-Do
Contributing
By submitting this pull request, I confirm the following: