Fix: align Alert Logs table with System Logs and Colourization from system logs tab - #367
Merged
TheWitness merged 2 commits intoSep 21, 2026
Conversation
- Alert Logs column order now matches the System Logs tab: date, device, severity, alert name, message, count, facility, priority - Alert rows reuse the syslog Kiwi pastel tint classes (logInfo/ logWarning/logAlert) so both tables share one color scheme; the hard-coded syslogAlertRow border rule is removed and the legend updated - Alert log CSV export reordered to match the new table order
bmfmancini
changed the title
bmfmancini
marked this pull request as ready for review
September 21, 2026 03:47
TheWitness
previously approved these changes
Sep 21, 2026
TheWitness
approved these changes
Sep 21, 2026
TheWitness
added a commit
that referenced
this pull request
Sep 21, 2026
…ctions.php (#368) PR #367 inserted a new docblock/signature for syslog_log_row_color() above the existing one without removing the old docblock's remaining lines, leaving stray comment text (starting with `* displayed. It supports...`) between the function's opening brace and its body. This is a syntax error ("unexpected token *") that fails plugin install in CI. Removes the leftover duplicate docblock and function declaration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Alert Logs table so it matches the System Logs table:
logInfo/logWarning/logAlertclasses onsyslogRow), replacing the hard-codedsyslogAlertRowred left border. The severity legend above the Alert Log table was updated to match.Notes
develop(an earlier noisy branch with unrelated merge commits was replaced by this one).php -lpasses on changed files;tests/Unit(68 tests) andtests/Security(39 tests) pass against Cacti's vendor tree.