ci: fail workflow on FATAL/ERROR/WARNING in Cacti log - #821
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The log check must reliably handle permissions and read errors.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a CI step to scan cacti.log for FATAL:, ERROR:, and WARNING: entries and fail the workflow when found.
Changes:
- Adds post-log-display severity checking.
- Runs the check even after prior failures.
- Moderate finding (3 votes): unreadable root-owned logs may silently bypass the check; use
sudoand handlegreperrors explicitly.
File summaries
| File | Summary |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Adds Cacti log severity detection. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xmacan
previously approved these changes
Sep 15, 2026
xmacan
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new step after View Cacti Logs that greps the full
cacti.logfor the stringsFATAL:,ERROR:,WARNING:and fails the job if any are found.