Skip to content

feat: add Dockerfile and .dockerignore for containerization - #4

Merged
CallMeLeon167 merged 8 commits into
CallMeLeon167:mainfrom
nielsklumper:dockerize-server
Apr 20, 2026
Merged

feat: add Dockerfile and .dockerignore for containerization#4
CallMeLeon167 merged 8 commits into
CallMeLeon167:mainfrom
nielsklumper:dockerize-server

Conversation

@nielsklumper

Copy link
Copy Markdown
Contributor

No description provided.

@CallMeLeon167 CallMeLeon167 added the enhancement New feature or request label Apr 16, 2026
@CallMeLeon167 CallMeLeon167 self-assigned this Apr 16, 2026
@CallMeLeon167

Copy link
Copy Markdown
Owner

Hey @nielsklumper, thanks for your pull request. Getting the whole thing up and running with Docker was already on my to-do list, so thanks!

I’ve got a few things to mention, though.

I’d actually quite like to have a Docker Compose file for this. I’ve quickly put one together: docker-compose.yml
It’d be really great if you could push this up too.

Now that there is a Docker Compose file, can you update the devcontainer.json to use it?

I’m not very familiar with devcontainer.json files, but this snippet (or a modified version) should work 🤷‍♂️:

"dockerComposeFile": [ "../docker-compose.yml" ], "service": "app", "runServices": [ "app" ], "overrideCommand": false, "workspaceFolder": "/var/www/html", "forwardPorts": [ 8080 ],

P.S.: I've updated the base path URL in index.php, so please pull from the main branch again.

@CallMeLeon167
CallMeLeon167 merged commit b53193d into CallMeLeon167:main Apr 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants