Firefly-2048: fix bug in reading tables with TZERO - #1994
Open
robyww wants to merge 1 commit into
Open
Conversation
- nom-tam-fits bug: hduTable.getColumnMeta(icol, "TZERO") will return a null. The problem seems to be with the nom-tam-fits function - We do not handle longs correctly when we need to scale them. We are converting the long to a double - Fixed the two bugs, implement a work around convenience function for getColumnMeta and do the right thing with longs. - A little clean up on HiPSRetrieve.java
robyww
force-pushed
the
FIREFLY-2048-fits-tzero
branch
from
August 12, 2026 22:48
52e7e30 to
c965120
Compare
robyww
marked this pull request as ready for review
August 12, 2026 22:54
|
If we think this is also a nom-tam-fits bug, can we also file a ticket with them? |
Contributor
Author
|
I am going to make a nom-tam-fits issue soon. |
Contributor
Author
|
nom-tam-fits issue: nom-tam-fits/nom-tam-fits#882 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2048: fix bug in reading tables with TZERO
Testing
DP2 & DP2 ImagesObservation Type and Source->Collection-> LSST.DP2SearchFile Contentspull down to go toHDU #9and show the table.int,int,long,intdata-intto see the wrong data