Add optional AI opponent name to puzzles, with new Duelist #5 puzzle "Eeny Meeny Miney Moe" - #11620
Open
dennisfriedrichsen wants to merge 17 commits into
Open
Add optional AI opponent name to puzzles, with new Duelist #5 puzzle "Eeny Meeny Miney Moe"#11620dennisfriedrichsen wants to merge 17 commits into
dennisfriedrichsen wants to merge 17 commits into
Conversation
dennisfriedrichsen
marked this pull request as ready for review
August 14, 2026 23:39
Contributor
|
Looks alright to me, the HostedMatch modification needs additional review imo because I'm not sure if that implementation is sturdy enough (not my area of expertise), otherwise lgtm. |
Agetian
self-requested a review
August 15, 2026 05:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AINamemetadata field in.pzlpuzzle files, which is displayed to the player as "Opponent: " in the puzzle goal description.namefield toGameState.PlayerStateand wire it up inparseLine/setupPlayerStateso that ahumanName=/aiName=line in a puzzle's[state]section actually sets the player's display name in-game (this key already existed unused in some puzzle files).Details
Puzzle.java: parsesAINamefrom[metadata], exposes it viagetAIName(), and includes it ingetGoalDescription().GameState.java: generic prefix/suffix key dispatch already handledhuman/aiprefixes; this adds anamesuffix so<player>Name=in the[state]section callsPlayer.setName()during setup.Duelist_Number_5.pzl: new puzzle file exercising both the new metadata field and per-cardSet:3EDtagging.Test plan
AIName/Namestate keys still load and behave unchanged