Skip to content

[ENG-9046][followup] fix rss/atom validation errors#887

Merged
aaxelb merged 2 commits into
CenterForOpenScience:developfrom
aaxelb:feat/9046/shtrove-rss-followup
Oct 28, 2025
Merged

[ENG-9046][followup] fix rss/atom validation errors#887
aaxelb merged 2 commits into
CenterForOpenScience:developfrom
aaxelb:feat/9046/shtrove-rss-followup

Conversation

@aaxelb

@aaxelb aaxelb commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

fix validation errors found on index-card-search rss/atom feeds

  • atom renderer (see validation report, now fixed)
    • <link href="..." /> instead of <link>...</link>
    • add <updated> feed element
    • fix missing <author>
    • only one <uri> per <author>
    • include filename as additional title
  • rss renderer (see validation report, now fixed)
    • use dc:creator instead of author (which can occur only once and requires email address)
    • use filename for title when title missing
    • add self-link <atom:link rel="self" ...
  • also add feed links to plain json rendering

@aaxelb aaxelb requested a review from felliott October 24, 2025 15:53
@coveralls

coveralls commented Oct 24, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 84.4% (+0.1%) from 84.29%
when pulling 8d48649 on aaxelb:feat/9046/shtrove-rss-followup
into 71ebed7 on CenterForOpenScience:develop.

@felliott felliott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Approved!

Cheers,
@felliott

@aaxelb aaxelb merged commit c35c715 into CenterForOpenScience:develop Oct 28, 2025
3 checks passed
@aaxelb aaxelb deleted the feat/9046/shtrove-rss-followup branch October 28, 2025 13:17
@aaxelb aaxelb mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants