CI Fix on dev#1277
Merged
Merged
Conversation
kantagara
approved these changes
Jan 22, 2025
kantagara
left a comment
kantagara
left a comment
Contributor
There was a problem hiding this comment.
One question tho: Wouldn't this cause some issues in runtime? Since lightweight instance/heavyweight instance wouldn't be initialized if rememberConnection is set to false? Oir they wil be?
Collaborator
Author
|
juans-chainsafe
approved these changes
Jan 22, 2025
rob1997
added
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were initializing web3 twice on dev which was causing all sorts of issues because
OnWeb3Initializedcallback was calling twice, here's a test action run