feat(pinia-orm): Pinia setup store syntax support#1905
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
==========================================
+ Coverage 99.48% 99.55% +0.06%
==========================================
Files 86 86
Lines 3124 3142 +18
Branches 526 530 +4
==========================================
+ Hits 3108 3128 +20
+ Misses 14 12 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/pinia-orm/.eslintcache
CodeDredd
added a commit
that referenced
this pull request
Jul 20, 2026
The setup store support (#1905) imports ref from vue, but vue was never declared as a peer dependency. Package managers could not warn on incompatible vue versions and size-limit bundled vue's reactivity system into the measurement, inflating it from 11.75 kB to 16.18 kB brotli. The index size limit is lowered back to 12 kB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves: #1888
📚 Description
It adds support for the pinia setup store. Downside...it also add 4KB to the bundle size...