feat(pinia-orm)!: require node >= 22 and support pinia 4#2046
Merged
Conversation
BREAKING CHANGE: all packages now require Node.js >= 22.12, in sync with Nuxt 4 (^22.19) and current Vite. CI runs on Node 22. The test suites now run against pinia 4 (all green, no code changes needed) - the peer dependency stays >=3.0.0 so both majors work. @pinia/testing updated to v2.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2046 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 82 82
Lines 3100 3100
Branches 559 559
=======================================
Hits 3078 3078
Misses 16 16
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node >= 22 (breaking, for 2.0.0)
Decision: Node >= 22.12 instead of 24 —
^22.19 || ^24.11, Vite requires^20.19 || >=22.12→ 22 is the ecosystem anchorChanges:
engines.node >= 22.12in all four packages, CI/changelog/release workflows bumped from Node 20 to 22 (.nvmrc already was 22).pinia 4
pinia 4.0.2 is out. Full pinia-orm + axios suites run green against it without any code changes (426 + 25 tests). Dev dependencies now use pinia 4 + @pinia/testing 2, so CI permanently tests against pinia 4; the peer dependency stays
>=3.0.0, so users on pinia 3 keep working.No Node-22-specific refactors included on purpose — nothing in the codebase currently pays for them (no legacy Buffer/URL/crypto usage); can be done as a follow-up if something comes up.