Jazzer Pro

.bazelrc

@@ -10,34 +10,53 @@ build --nozip_undeclared_test_outputs
 # C/C++
 # GCC is supported on a best-effort basis.
 common --repo_env=CC=clang
-# Required by abseil-cpp.
-build --cxxopt=-std=c++14
+# On Linux, use a hermetic toolchain and sysroot shared between local dev setups and CI.
+# Such a toolchain isn't easily available on macOS or Windows.
+common:linux --repo_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
+common:linux --extra_toolchains=@llvm_toolchain//:cc-toolchain-x86_64-linux
 # Silence protobuf compilation warnings.
+build --copt=-Wno-unused-function
+build --copt=-Wno-unknown-warning-option
 build --host_copt=-Wno-unused-function
 build --host_copt=-Wno-unknown-warning-option
-# Requires a relatively modern clang.
-build:ci --features=layering_check
+# Ensure that cc_* targets declare all their direct dependencies (requires clang).
+# TODO: This is currently ignored by the hermetic toolchain used on Linux.
+# See: https://github.com/grailbio/bazel-toolchain/issues/203
+build --features=layering_check
 build:macos --apple_crosstool_top=@local_config_apple_cc//:toolchain
 build:macos --crosstool_top=@local_config_apple_cc//:toolchain
 build:macos --host_crosstool_top=@local_config_apple_cc//:toolchain
 
 # Java
-# Always build for Java 8, even with a newer JDK. This ensures that all
-# artifacts we release are compatible with Java 8 runtimes.
+# Always build for Java 8, even with a newer JDK. This ensures that all artifacts we release are
+# bytecode compatible with Java 8 runtimes. Runtime compatibility (e.g not using APIs that aren't
+# available in Java 8) is verified in CI.
 # Note: We would like to use --release, but can't due to
-#  https://bugs.openjdk.org/browse/JDK-8214165.
-build --javacopt=-target --javacopt=8
+# https://bugs.openjdk.org/browse/JDK-8214165.
 build --java_language_version=8
-build --tool_java_language_version=8
-# Use a hermetic JDK to compile Java code, which also means that contributors
-# don't need to install a JDK to compile Jazzer.
-build --java_runtime_version=remotejdk_17
-build --tool_java_runtime_version=remotejdk_17
+
+# Targeting Java 8 with JDK 21 is deprecated and results in this warning:
+# warning: [options] source value 8 is obsolete and will be removed in a future release
+# warning: [options] target value 8 is obsolete and will be removed in a future release
+# warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
+# Internally, Bazel always runs javac on a Java 21 runtime, but uses the classpath obtained from the
+# runtime configured below.
+build --javacopt=-Xlint:-options
+
+# Tools used during the build do not have compatibility requirements, so we can use the most recent
+# language features.
+build --tool_java_language_version=21
+
+# Compile for a hermetic JDK so that devs don't have to have a particular JDK installed and
+# configured locally.
+build --java_runtime_version=remotejdk_21
+build --tool_java_runtime_version=remotejdk_21
+
 # Speed up Java compilation by removing indirect deps from the compile classpath.
+# Only has an effect when used together with --disk_cache or --remote_cache.
 build --experimental_java_classpath=bazel
 
 # Android
-build --incompatible_enable_android_toolchain_resolution
 build --android_platforms=//:android_arm64
 
 # Windows
@@ -50,10 +69,6 @@ build:windows --features=static_link_msvcrt
 test:windows --noincompatible_strict_action_env
 run:windows --noincompatible_strict_action_env
 
-# Toolchain
-# Since the toolchain is conditional on OS and architecture, set it on the particular GitHub Action.
-common:toolchain --repo_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
-
 # Forward debug variables to tests
 build --test_env=JAZZER_AUTOFUZZ_DEBUG
 build --test_env=JAZZER_REFLECTION_DEBUG
@@ -82,10 +97,6 @@ build:ci --experimental_profile_include_primary_output
 build:ci --nolegacy_important_outputs
 common:ci --announce_rc
 
-# Docker images
-common:docker --config=toolchain
-common:docker --extra_toolchains=@llvm_toolchain//:cc-toolchain-x86_64-linux
-
 # Generic coverage configuration taken from https://github.com/fmeum/rules_jni
 coverage --combined_report=lcov
 coverage --experimental_use_llvm_covmap
@@ -102,3 +113,10 @@ coverage --test_tag_filters=-no-coverage
 # https://github.com/bazelbuild/bazel/issues/4867#issuecomment-830402410
 common:quiet --ui_event_filters=-info,-stderr
 common:quiet --noshow_progress
+
+# Use --config=fail-fast to speed up local iteration on tests by letting bazel test stop right on
+# the first failing test.
+# Let bazel test stop on the first failing test target.
+test:fail-fast --notest_keep_going
+# Instruct test runners to fail a test target on the first failing test.
+test:fail-fast --test_runner_fail_fast

.bazelversion

@@ -1 +1 @@
-1f12a4d8f82efa3eac5e1a708833e8ed53e54327
+7.3.0

.github/BUILD.bazel

@@ -3,6 +3,7 @@
 
 package(default_visibility = ["//visibility:public"])
 
+# Xcode version on public GitHub Actions macos-12 runners
 xcode_version(
     name = "version14_2_0_14C18",
     aliases = [
@@ -19,8 +20,28 @@ xcode_version(
     version = "14.2.0.14C18",
 )
 
+# Xcode version on public GitHub Actions macos-13 runners
+xcode_version(
+    name = "version15_2_0_15C500b",
+    aliases = [
+        "15.2.0.15C500b",
+        "15C500b",
+        "15.2.0",
+        "15.2",
+        "15",
+    ],
+    default_ios_sdk_version = "17.2",
+    default_macos_sdk_version = "14.2",
+    default_tvos_sdk_version = "17.1",
+    default_watchos_sdk_version = "10.2",
+    version = "15.2.0.15C500b",
+)
+
 xcode_config(
     name = "host_xcodes",
-    default = ":version14_2_0_14C18",
-    versions = [":version14_2_0_14C18"],
+    default = ":version15_2_0_15C500b",
+    versions = [
+        ":version15_2_0_15C500b",
+        ":version14_2_0_14C18",
+    ],
 )

.github/scripts/echoBuildBuddyConfig.sh

@@ -1,5 +1,14 @@
 #!/usr/bin/env bash
 
+#
+# Copyright 2024 Code Intelligence GmbH
+#
+# By downloading, you agree to the Code Intelligence Jazzer Terms and Conditions.
+#
+# The Code Intelligence Jazzer Terms and Conditions are provided in LICENSE-JAZZER.txt
+# located in the root directory of the project.
+#
+
 if [ -n "${1}" ]; then
   echo "BUILD_BUDDY_CONFIG=--config=ci --remote_header=x-buildbuddy-api-key=${1}";
 else

.github/workflows/check-formatting.yml

@@ -2,8 +2,6 @@ name: Check formatting
 
 # Controls when the action will run.
 on:
-  push:
-    branches: [ main ]
   pull_request:
     branches: [ main ]
   merge_group:
@@ -12,10 +10,10 @@ on:
 
 jobs:
   check_formatting:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Run format.sh and print changes
         env:

.github/workflows/datadog.yaml

@@ -6,7 +6,7 @@ on:
 
 jobs:
   send-release-event:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: Send Release Event
         run: |

.github/workflows/prerelease.yaml

@@ -12,21 +12,21 @@ jobs:
     strategy:
       matrix:
         include:
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             name: linux
-          - os: macos-11
+          - os: macos-13
             name: macos
           - os: windows-2019
             name: windows
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Set up JDK
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           distribution: zulu
-          java-version: 8
+          java-version: 21
 
       - name: Append build settings to .bazelrc
         shell: bash
@@ -35,8 +35,6 @@ jobs:
           echo "build --remote_header=x-buildbuddy-api-key=${{ secrets.BUILDBUDDY_API_KEY }}" >> .bazelrc
           echo "build --config=ci" >> .bazelrc
           echo "build --//deploy:jazzer_version=${TAG#v}" >> .bazelrc
-          echo "build:linux --config=toolchain" >> .bazelrc
-          echo "build:linux --extra_toolchains=@llvm_toolchain//:cc-toolchain-x86_64-linux" >> .bazelrc
 
       - name: Build
         shell: bash
@@ -48,30 +46,31 @@ jobs:
           cp -L $(bazel cquery --output=files :jazzer_release) jazzer-${{ matrix.name }}.tar.gz
 
       - name: Upload jazzer.jar
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: jazzer_tmp
+          name: jazzer_tmp_${{ matrix.name }}
           path: jazzer-${{ matrix.name }}.jar
           if-no-files-found: error
 
       - name: Upload release archive
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: jazzer_releases
+          name: jazzer_releases_${{ matrix.name }}
           path: jazzer-${{ matrix.name }}.tar.gz
           if-no-files-found: error
 
   merge_jars:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     needs: build_release
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Download individual jars
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: jazzer_tmp
+          pattern: jazzer_tmp_*
+          merge-multiple: true
           path: _tmp/
 
       - name: Merge jars
@@ -81,26 +80,24 @@ jobs:
             $(find "$(pwd)/_tmp/" -name '*.jar' -printf "--sources %h/%f ")
 
       - name: Upload merged jar
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: jazzer
           path: _tmp/jazzer.jar
           if-no-files-found: error
 
   maven_predeploy:
-    # TODO: Our hermetic toolchain doesn't support ubuntu-latest yet and fails with:
-    # external/llvm_toolchain_llvm/bin/clang: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: merge_jars
 
     environment:
       name: Deploy
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Set up JDK
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           distribution: zulu
           java-version: 8
@@ -112,11 +109,9 @@ jobs:
           echo "build --remote_header=x-buildbuddy-api-key=${{ secrets.BUILDBUDDY_API_KEY }}" >> .bazelrc
           echo "build --config=ci" >> .bazelrc
           echo "build --//deploy:jazzer_version=${TAG#v}" >> .bazelrc
-          echo "build:linux --config=toolchain" >> .bazelrc
-          echo "build:linux --extra_toolchains=@llvm_toolchain//:cc-toolchain-x86_64-linux" >> .bazelrc
 
       - name: Download merged jar
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: jazzer
           path: _tmp/
@@ -131,23 +126,24 @@ jobs:
 
   create_release:
     needs: build_release
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     permissions:
       contents: write # for creating releases
 
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Download individual tar.gzs
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: jazzer_releases
+          pattern: jazzer_releases_*
+          merge-multiple: true
           path: _releases/
 
       - name: create release
-        uses: softprops/action-gh-release@c9b46fe7aad9f02afd89b12450b780f52dacfb2d
+        uses: softprops/action-gh-release@4634c16e79c963813287e889244c50009e7f0981
         with:
           generate_release_notes: true
           draft: true