Extend KeyDownTriggerBehavior with Modifiers and ability to handle already handled events#853
Conversation
…nts, and modifier keys
Irina-Konovalova
force-pushed
the
key-down-trigger-behavior-improvements
branch
from
6b836a3 to
8b01b15
Compare
|
@dotnet-policy-service agree company="ECIERGE SOFTWARE DEV INC" |
There was a problem hiding this comment.
I think this is a great PR. I love the additional functionality, and I appreciate the coding style such as using guard clauses. However, I dislike the repeated calls to InputKeyboardSource.GetKeyStateForCurrentThread. I do love small purposeful helper functions, but not at the expense of ideal behavior. Let's see about moving the state check into CheckModifiers and inlining IsDown inside Match using the state retrieved in CheckModifiers.
There's also a somewhat trivial code styling question spawned by this PR regarding the ordering of class members. Hoping to get a definitive answer on that soon.
| /// <returns><see langword="true"/> if the key is pressed; otherwise, <see langword="false"/>.</returns> | ||
| private static bool IsDown(VirtualKey key) | ||
| { | ||
| var state = InputKeyboardSource.GetKeyStateForCurrentThread(key); |
There was a problem hiding this comment.
Let's change this so it's called once in CheckModifiers and the flags are handled from that one request.
| [TypeConstraint(typeof(FrameworkElement))] | ||
| public class KeyDownTriggerBehavior : Trigger<FrameworkElement> | ||
| { | ||
| private KeyEventHandler? _handler; |
There was a problem hiding this comment.
| private KeyEventHandler? _handler; | |
| private KeyEventHandler? _handler; | |
Small formatting thing. Let's add a space here. Also, personally I would put all the DependencyProperty declarations together and all the property declarations below, but we don't currently have a uniform convention on this, and this PR has actually sparked a debate on this in the Discord.
2 participants
Fixes
This PR extends
KeyDownTriggerBehavior.PR Type
What kind of change does this PR introduce?
KeyDownTriggerBehaviorwithModifiersand ability to handle already handled events.What is the current behavior?
KeyDownTriggerBehaviordoes not support modifier keys or PreviewKeyDown, which limits its use in keyboard navigation scenarios.What is the new behavior?
This PR extends
KeyDownTriggerBehaviorby adding support for modifier keys, PreviewKeyDown, and handled events. It also updates the XML documentation.PR Checklist
Please check if your PR fulfills the following requirements:
Other information