ci: fix broken Slack notification workflows (incoming-webhook)#10
Merged
Conversation
Coverage Report
|
…o v6.1.1 (zizmor ref-version-mismatch)
…e output delimiter
…ncurrency/region/comments
…e region env, harden pack/secret guards
…cret names in guard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Slack Open PRs Notification and Slack Issue Notification workflows failed on every run with
SlackError: Missing input! Either a method or webhook is required. They usedslackapi/slack-github-action'swebhook-type: webhook-trigger(Slack Workflow Builder) pointed at a secret that was never set — but the org standard, and the only webhook URL available, is an incoming-webhook. This converts both workflows to the org-canonical incoming-webhook pattern so they deliver to#oss-alerts, and hardens the surrounding workflow code.Slack notifications
slackapi/slack-github-actionpinned tob0fa283…(v2.1.0),webhook-type: incoming-webhook, message-shaped{ "text": ... }payload built withtoJSON(format(...))so PR/issue titles escape into valid JSON.SLACK_WEBHOOK_OSS_ALERTS(→#oss-alerts), matching the rest of the org. The secret is set on this repo.GITHUB_OUTPUTdelimiter.e2e workflows (hardening, surfaced while touching
.github/workflows/**)--branch mainto match the step's stated intent.npm pack --json | jqcapture with a non-empty/nullassertion;set -euo pipefailon the touched shell blocks.CDK_REPO_NAME/CDK_REPO_TOKENsecrets before the clone, with an operator-facing error message.e2e-tests-fullconcurrency group (dropped a deadgithub.event.pull_request.numberreference).type: stringto theaws_regioninput.aws-actions/configure-aws-credentialsversion comment (# v6→# v6.1.1) so the repo's zizmor static-analysis gate passes on workflow changes.Test plan
workflow_dispatch— posted the digest to#oss-alerts(HTTP 200, no "Missing input" error).actionlintandzizmor(--min-severity medium) clean on all four workflow files.--branch mainpin.