Skip to content

Tinymce label fix #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raycarrick-ed merged 2 commits into from
Sep 22, 2021
Merged

Tinymce label fix #3032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4976196
fixes an issue where the tinymce editor is not linking to the correct…
briri Sep 21, 2021
ac25985
fixed typo in js changes
briri Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions app/javascript/src/utils/tinymce.js.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,13 @@ const resizeEditors = (editors) => {
behind the scenes) to the Tinymce iframe so that screen readers read the correct
label when the tinymce iframe receives focus.
*/
const attachLabelToIframe = (tinymceContext) => {
const attachLabelToIframe = (tinymceContext, hiddenFieldSelector) => {
const iframe = $(tinymceContext).siblings('.mce-container').find('iframe');
if (isObject(iframe)) {
const lbl = iframe.closest('form').find('label');
const hiddenField = $(hiddenFieldSelector);

if (isObject(iframe) && isObject(hiddenField)) {
const id = hiddenField.attr('id');
const lbl = iframe.closest('form').find(`label[for="${id}"]`);
if (isObject(lbl)) {
// Connect the label to the iframe
lbl.attr('for', iframe.attr('id'));
Expand All @@ -93,7 +96,7 @@ export const Tinymce = {

// Connect the label to the Tinymce iframe
$(options.selector).each((idx, el) => {
attachLabelToIframe(el);
attachLabelToIframe(el, options.selector);
});
},
/*
Expand Down