added handler for Pundit errors on ApplicationController#3036
Merged
Conversation
raycarrick-ed
approved these changes
Sep 28, 2021
raycarrick-ed
left a comment
raycarrick-ed
left a comment
Contributor
There was a problem hiding this comment.
Looks an improvement.
Contributor
|
The test failures look like a consequence of the exception handling change so just eed changed to be new results. I think. |
Contributor
Author
|
fixed up the tests |
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
added handler for Pundit errors on ApplicationController
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just building off of the pattern @johnpinto1 established for us for handling errors.
This ensures that any Pundit authorization errors result in an Unauthorized error message and brings the user back to their Dashboard or the homepage if they're not logged in