Skip to content

Patch issue causing template visibility to get set to organizationally visible#3299

Merged
briri merged 7 commits into
mainfrom
template-update-fix
Mar 23, 2023
Merged

Patch issue causing template visibility to get set to organizationally visible#3299
briri merged 7 commits into
mainfrom
template-update-fix

Conversation

@briri

@briri briri commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

When an admin saves changes to their template on the template details page, the visibility os getting automatically set to 'organizationally_visible' this patch carries forward whatever the current value is.

@briri briri requested a review from johnpinto1 March 23, 2023 16:01

@johnpinto1 johnpinto1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@briri

briri commented Mar 23, 2023

Copy link
Copy Markdown
Contributor Author

ok. I'm going to see if I can fix the failing Github action. Looks like node might be out of date on the CI builds

@johnpinto1

Copy link
Copy Markdown
Contributor

@briri No hurry as we can still use patch.

@briri

briri commented Mar 23, 2023

Copy link
Copy Markdown
Contributor Author

GitHub actions have been patched thanks to @pengyin-shan recommendation on PR #3288 to lock node at v16.6 (for now anyway)

@briri briri merged commit 21ce204 into main Mar 23, 2023
@briri briri deleted the template-update-fix branch March 23, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants